Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-OCC-xxx] All tests use endpoint = self.user_params.get("endpoint", 1) which is wrong #340

Closed
tcarmelveilleux opened this issue Aug 14, 2024 · 0 comments · Fixed by project-chip/connectedhomeip#35001
Labels

Comments

@tcarmelveilleux
Copy link

Description:

All the TC-OCC-* scripts determine the endpoint using endpoint = self.user_params.get("endpoint", 1) instead of endpoint = self.matter_test_config.endpoint which requires separate "int_args": "endpoint:N" arguments in test_parameters that clashes with the endpoint test_parameter

Steps to reproduce:

Run any TC-OCC-* test without "int_args": "endpoint:N"` extra argument. See failure due to attribute not found on endpoint if endpoint of occupancy sensor is not == 1.

tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Aug 14, 2024
- During TE2 if was found that all TC-OCC-* tests require
  to pass a `--int-arg endpoint:N` argument which is not the right
  way to specify endpoint. This is fixed here.
- Some pre-steps were done in Step 1 which should have been done after Step 1
  so that errors are not marked as Commissioning Failure when it's test failure.

Fixes project-chip/matter-test-scripts#340
@raju-apple raju-apple added Found_1.4_TE2 v1.4 Issues found in 1.4 Timeframe labels Aug 16, 2024
PeterC1965 pushed a commit to PeterC1965/connectedhomeip that referenced this issue Aug 28, 2024
* Fix init of all TC-OCC-* tests

- During TE2 if was found that all TC-OCC-* tests require
  to pass a `--int-arg endpoint:N` argument which is not the right
  way to specify endpoint. This is fixed here.
- Some pre-steps were done in Step 1 which should have been done after Step 1
  so that errors are not marked as Commissioning Failure when it's test failure.

Fixes project-chip/matter-test-scripts#340

* More fixes to OCC tests

- 3.2 now properly using feature map
- Fixed typos
- Added queue flushing examples

* Restyle

* Fix line endings

* Restyled by autopep8

* Fix CI

---------

Co-authored-by: Restyled.io <[email protected]>
ArekBalysNordic pushed a commit to ArekBalysNordic/sdk-connectedhomeip that referenced this issue Nov 28, 2024
* Fix init of all TC-OCC-* tests

- During TE2 if was found that all TC-OCC-* tests require
  to pass a `--int-arg endpoint:N` argument which is not the right
  way to specify endpoint. This is fixed here.
- Some pre-steps were done in Step 1 which should have been done after Step 1
  so that errors are not marked as Commissioning Failure when it's test failure.

Fixes project-chip/matter-test-scripts#340

* More fixes to OCC tests

- 3.2 now properly using feature map
- Fixed typos
- Added queue flushing examples

* Restyle

* Fix line endings

* Restyled by autopep8

* Fix CI

---------

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants