Fix TLV test to produce more useful failure output. #9934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
tlv-better-test-output
branch
from
58f8c5d to
c0ff4c2
Compare
Assertions inside the Get<> function are hard to trace back to the actual Get<> caller, because they just list the line number of the Get<> function. Replace it with a macro, so we get more useful output on failure.
bzbarsky-apple
force-pushed
the
tlv-better-test-output
branch
from
c0ff4c2 to
b283b47
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux and
vivien-apple
LuDuda
approved these changes
Sep 23, 2021
saurabhst
approved these changes
Sep 23, 2021
jmartinez-silabs
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assertions inside the Get<> function are hard to trace back to the
actual Get<> caller, because they just list the line number of the
Get<> function. Replace it with a macro, so we get more useful output
on failure.
Problem
See above.
Change overview
See above.
Testing
Ran the test; it passed.
The original fix was provided by @bitkis in #5764