Fix intermittent failure in TestReliableMessageProtocol. #9927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are ending up with queued retransmits on both the initiator and responder. The responder has a much longer retransmit interval, but when we sleep for the initiator to retransmit, we can end up sleeping too long, so the responder retransmits too. Make the test handle both cases.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
turon,
vivien-apple and
woody-apple
saurabhst
approved these changes
Sep 23, 2021
msandstedt
approved these changes
Sep 23, 2021
andy31415
approved these changes
Sep 23, 2021
yufengwangca
approved these changes
Sep 23, 2021
|
@LuDuda @Damian-Nordic @woody-apple @jepenven-silabs @jmartinez-silabs Please take a look? |
LuDuda
approved these changes
Sep 23, 2021
jmartinez-silabs
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are ending up with queued retransmits on both the initiator and
responder. The responder has a much longer retransmit interval, but
when we sleep for the initiator to retransmit, we can end up sleeping
too long, so the responder retransmits too. Make the test handle both
cases.
Problem
Intermittent failures like https://github.com/project-chip/connectedhomeip/runs/3682099087
Change overview
Make those cases not fail.
Testing
Ran this locally, twiddled the MRP settings to make sure I exercised both branches, and made sure that both branches pass.