Upload diagnostic logs on Darwin if the build+unit-test task fails. #9891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might allow us some slightly better visibility into unit test crashes on Darwin.
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
saurabhst,
shana-apple,
turon,
vivien-apple,
woody-apple and
yufengwangca
saurabhst
approved these changes
Sep 22, 2021
LuDuda
approved these changes
Sep 22, 2021
jmartinez-silabs
approved these changes
Sep 23, 2021
jmartinez-silabs
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might allow us some slightly better visibility into unit test
crashes on Darwin.
Problem
We have intermittent unit test crashes on Darwin and we have no idea why
Change overview
Upload diagnostic logs so we can at least get a stack.
Testing
Introduced a purposeful crash in a unit test and pushed to my fork; checked that the CI run uploaded the diagnostic log.