Fix some post-landing review comments for rotating device id. #9804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specific changes: 1) Use `MutableButeSpan foo(bar)` instead of `MutableByteSpan foo = MutableByteSpan(bar)`. 2) Use the `Put` signature that takes ByteSpan when writing to the TLVWriter. 3) Fix some comments on generateRotatingDeviceIdAsBinary to make it clearer how the "in,out" param works. 4) Stop failing out for rotating device ids that are smaller than the max possible size. Add a test for this.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
turon,
vivien-apple and
woody-apple
msandstedt
approved these changes
Sep 17, 2021
hnnajh
approved these changes
Sep 17, 2021
hnnajh
reviewed
Sep 17, 2021
andy31415
approved these changes
Sep 20, 2021
|
@woody-apple @LuDuda @jepenven-silabs @jmartinez-silabs @Damian-Nordic Please take a look? |
yufengwangca
approved these changes
Sep 20, 2021
jmartinez-silabs
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific changes:
Use
MutableButeSpan foo(bar)instead ofMutableByteSpan foo = MutableByteSpan(bar).Use the
Putsignature that takes ByteSpan when writing to the TLVWriter.Fix some comments on generateRotatingDeviceIdAsBinary to make it
clearer how the "in,out" param works.
Stop failing out for rotating device ids that are smaller than the max
possible size. Add a test for this.
Problem
#9455 was merged before I got a chance to look at the final changes. Mostly nits, but the functional problem for "too short" rotating device ids was never fixed and the test I asked for was never added.
Change overview
Address the remaining issues.
Testing
New unit test passes.