Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Add ChipMdnsShutdown() #9668

Closed
wants to merge 1 commit into from

Conversation

hyunuktak
Copy link
Contributor

Problem

Issue #8001 MdnsAvahi destructor segfault; require separate shutdown

MdnsAvahi can cause a crash on exit due to a static instance running
code in its destructor after dependent components have shut down.

Change overview

  • Add ChipMdnsShutdown(). This is a narrow fix, which does not attempt
    to address other potential problems with singleton mDNS state.

@github-actions
Copy link

Size increase report for "esp32-example-build" from 64d8f13

File Section File VM
chip-temperature-measurement-app.elf .flash.text 56 56
chip-lock-app.elf .flash.text 80 80
chip-bridge-app.elf .flash.text -76 -76
chip-ipv6only-app.elf .flash.text -172 -172
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,56,56
[Unmapped],0,-56

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,80,80
.xt.prop._ZNK4chip4SpanIhE7SubSpanEjj,0,12
.xt.lit._ZNK4chip4SpanIhE7SubSpanEjj,0,8
.debug_loc,0,4
[Unmapped],0,-80

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
[Unmapped],0,76
.flash.text,-76,-76

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
.flash.text,-172,-172
[Unmapped],0,-3924


@kghost
Copy link
Contributor

kghost commented Sep 14, 2021

This is part of PR #9674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants