-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telink]: Fix entropy source failed crash on boot #9635
Merged
bzbarsky-apple
merged 6 commits into
project-chip:master
from
rikorsev:telink_fix_entropy_source_failed_crash
Sep 14, 2021
Merged
[Telink]: Fix entropy source failed crash on boot #9635
bzbarsky-apple
merged 6 commits into
project-chip:master
from
rikorsev:telink_fix_entropy_source_failed_crash
Sep 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
September 13, 2021 13:53
Size increase report for "esp32-example-build" from e945d16
Full report output
|
Size increase report for "nrfconnect-example-build" from e945d16
Full report output
|
msandstedt
approved these changes
Sep 13, 2021
andy31415
reviewed
Sep 13, 2021
andy31415
reviewed
Sep 13, 2021
woody-apple
approved these changes
Sep 13, 2021
kghost
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to automactically verify the issue by CI ? In case we may have regression problems like this one.
Damian-Nordic
requested changes
Sep 14, 2021
Damian-Nordic
approved these changes
Sep 14, 2021
bzbarsky-apple
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fix crash on startup for Telink platform with following log:
Investigation shows that the issue occurs due to changes made by this #9420 PR
Did previous solution works for nRF platform?
Any way, according to previous solution, srand() were called twice.
First time in ${chip_root}/src/platform/Zephyr/PlatformManagerImpl.cpp in _InitChipStack
Second time in ${chip_root}/src/platform/Entropy.cpp in InitEntropy
Change overview
Testing
Manually. Steps: