-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RawEndPoint. #9614
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-raw-endpoint
Sep 13, 2021
Merged
Remove RawEndPoint. #9614
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-raw-endpoint
Sep 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarmelveilleux
approved these changes
Sep 10, 2021
bzbarsky-apple
force-pushed
the
remove-raw-endpoint
branch
from
September 10, 2021 21:51
14ccb4d
to
ab771de
Compare
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
woody-apple
September 10, 2021 21:53
bzbarsky-apple
force-pushed
the
remove-raw-endpoint
branch
2 times, most recently
from
September 11, 2021 01:38
ebb6e3e
to
a6ff2ed
Compare
This is unused in Matter. The only use case is ICMP, and Matter doesn't do ICMP.
bzbarsky-apple
force-pushed
the
remove-raw-endpoint
branch
from
September 11, 2021 02:03
a6ff2ed
to
de976ee
Compare
Size increase report for "esp32-example-build" from eda07d5
Full report output
|
msandstedt
approved these changes
Sep 11, 2021
saurabhst
approved these changes
Sep 13, 2021
Damian-Nordic
approved these changes
Sep 13, 2021
andy31415
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unused in Matter. The only use case is ICMP, and Matter
doesn't do ICMP.
Problem
Dead (and buggy, which is why I was looking at it) code.
Change overview
Remove the code.
Testing
Unit tests still pass.