-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Wait till NimBLE host-cotroller is synced #9565
Merged
woody-apple
merged 2 commits into
project-chip:master
from
shubhamdp:esp32/fix_nimble_host_ctr_sync_and_readme
Sep 13, 2021
Merged
ESP32: Wait till NimBLE host-cotroller is synced #9565
woody-apple
merged 2 commits into
project-chip:master
from
shubhamdp:esp32/fix_nimble_host_ctr_sync_and_readme
Sep 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamdp
force-pushed
the
esp32/fix_nimble_host_ctr_sync_and_readme
branch
from
September 9, 2021 13:16
2cb64aa
to
eaa3021
Compare
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
vivien-apple
September 9, 2021 13:17
andy31415
approved these changes
Sep 9, 2021
Signed-off-by: Shubham Patil <[email protected]>
shubhamdp
force-pushed
the
esp32/fix_nimble_host_ctr_sync_and_readme
branch
from
September 9, 2021 13:28
eaa3021
to
b102f09
Compare
Signed-off-by: Shubham Patil <[email protected]>
shubhamdp
force-pushed
the
esp32/fix_nimble_host_ctr_sync_and_readme
branch
from
September 9, 2021 13:38
b102f09
to
0cc928c
Compare
Thanks a lot @shubhamdp! LGTM |
dhrishi
approved these changes
Sep 9, 2021
Size increase report for "esp32-example-build" from c65b91c
Full report output
|
bzbarsky-apple
approved these changes
Sep 9, 2021
Can this be reviewed and merged? cc @woody-apple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
temperature-measurement-app/esp32
readme file.temperature-measurement-app/esp32
Testing
all-clusters-app/esp32
at 80 MHz CPU frequency and BLE manager was able to configure the advertising data.