Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32: Wait till NimBLE host-cotroller is synced #9565

Conversation

shubhamdp
Copy link
Contributor

Problem

  • If NimBLE host-controller is not synced then BLE manager fails to configure advertising data. This is observed when ESP32 is configure to run at 80 MHz CPU frequency.

Change overview

  • Waiting on a semaphore to till NimBLE host-controller sync completes.
  • Some fixes in temperature-measurement-app/esp32 readme file.
  • Added a config option to add 8K RTC memory to heap in unicore mode in temperature-measurement-app/esp32

Testing

  • Build, flash and monitor all-clusters-app/esp32 at 80 MHz CPU frequency and BLE manager was able to configure the advertising data.

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2021

CLA assistant check
All committers have signed the CLA.

@shubhamdp shubhamdp force-pushed the esp32/fix_nimble_host_ctr_sync_and_readme branch from eaa3021 to b102f09 Compare September 9, 2021 13:28
@shubhamdp shubhamdp force-pushed the esp32/fix_nimble_host_ctr_sync_and_readme branch from b102f09 to 0cc928c Compare September 9, 2021 13:38
@dhrishi
Copy link
Contributor

dhrishi commented Sep 9, 2021

Thanks a lot @shubhamdp! LGTM

@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Size increase report for "esp32-example-build" from c65b91c

File Section File VM
chip-shell.elf .flash.text 92 92
chip-shell.elf .flash.rodata 48 48
chip-bridge-app.elf .flash.text 156 156
chip-bridge-app.elf .flash.rodata 48 48
chip-bridge-app.elf .dram0.bss 0 8
chip-temperature-measurement-app.elf .flash.text 24 24
chip-temperature-measurement-app.elf .dram0.bss 0 8
chip-lock-app.elf .flash.text 84 84
chip-lock-app.elf .flash.rodata 56 56
chip-lock-app.elf .dram0.bss 0 8
chip-ipv6only-app.elf .flash.text 172 172
chip-all-clusters-app.elf .flash.text 112 112
chip-all-clusters-app.elf .flash.rodata 56 56
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,267
.debug_line,0,194
.flash.text,92,92
.strtab,0,63
.debug_loc,0,57
.flash.rodata,48,48
.debug_abbrev,0,28
.debug_ranges,0,24
.debug_str,0,18
.symtab,0,16
.shstrtab,0,1
[Unmapped],0,-140

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.debug_info,0,267
.debug_line,0,194
.flash.text,156,156
.debug_loc,0,65
.strtab,0,63
.flash.rodata,48,48
.debug_abbrev,0,28
.debug_ranges,0,24
.symtab,0,16
.debug_str,0,14
.dram0.bss,8,0
.shstrtab,0,1
[Unmapped],0,-204

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.debug_info,0,170
.debug_line,0,87
.strtab,0,63
.debug_abbrev,0,28
.debug_ranges,0,24
.flash.text,24,24
.debug_str,0,17
.symtab,0,16
.dram0.bss,8,0
.shstrtab,0,1
.debug_loc,0,-6
[Unmapped],0,-24

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.debug_info,0,267
.debug_line,0,194
.debug_loc,0,89
.flash.text,84,84
.strtab,0,63
.flash.rodata,56,56
.debug_abbrev,0,28
.debug_ranges,0,24
.symtab,0,16
.debug_str,0,14
.dram0.bss,8,0
.shstrtab,0,1
[Unmapped],0,-140

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,3924
.flash.text,172,172

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,200
.flash.text,112,112
.debug_line,0,104
.strtab,0,63
.flash.rodata,56,56
.debug_loc,0,44
.debug_abbrev,0,28
.debug_str,0,16
.symtab,0,16
.shstrtab,0,1
.debug_frame,0,-8
[Unmapped],0,-168


@dhrishi
Copy link
Contributor

dhrishi commented Sep 11, 2021

Can this be reviewed and merged? cc @woody-apple

@woody-apple woody-apple merged commit d3b4b7e into project-chip:master Sep 13, 2021
@shubhamdp shubhamdp deleted the esp32/fix_nimble_host_ctr_sync_and_readme branch September 14, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants