Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestDevice CI error #9560

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Sep 9, 2021

Problem

Change overview

  • Replace virtual class System::Layer with System::LayerImpl
  • Add clean exit

Testing

CI build.

@gjc13
Copy link
Contributor Author

gjc13 commented Sep 9, 2021

The CI reported a segfault with RTTI enabled. Fix also added to this PR.

@gjc13 gjc13 changed the title fix TestDevice build error fix TestDevice CI error Sep 9, 2021
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

Size increase report for "esp32-example-build" from 741ab0a

File Section File VM
chip-shell.elf .flash.text 48 48
chip-lock-app.elf .flash.text 60 60
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.flash.text,48,48
[Unmapped],0,-48

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,60,60
.debug_loc,0,4
.xt.lit._ZNK4chip4SpanIhE7SubSpanEjj,0,-8
.xt.prop._ZNK4chip4SpanIhE7SubSpanEjj,0,-12
[Unmapped],0,-60

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize


@andy31415 andy31415 merged commit c65b91c into project-chip:master Sep 9, 2021
kpschoedel pushed a commit to kpschoedel/connectedhomeip that referenced this pull request Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controller hotfix urgent fix needed, can bypass review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants