-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endian-ness enforcement of generated compressed fabric ID #9488
Merged
woody-apple
merged 2 commits into
project-chip:master
from
pan-apple:compressed-id-endianness
Sep 7, 2021
Merged
Endian-ness enforcement of generated compressed fabric ID #9488
woody-apple
merged 2 commits into
project-chip:master
from
pan-apple:compressed-id-endianness
Sep 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
September 5, 2021 00:27
Size increase report for "esp32-example-build" from 92309bc
Full report output
|
andy31415
reviewed
Sep 7, 2021
andy31415
approved these changes
Sep 7, 2021
jmartinez-silabs
approved these changes
Sep 7, 2021
- Optimize persistent storage of NOC and Root Cert in FabricInfo.connectedhomeip/src/transport/FabricTable.h Lines 127 to 130 in 6c71631
This comment was generated by todo based on a
|
woody-apple
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The generated compressed fabric ID may be different for the same input for different platforms based on endianness.
Change overview
Convert generated compressed fabric ID to host system.
Testing
Added a new unit test that checks for generated compressed fabric ID against expected values for a given set of test inputs.