Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endian-ness enforcement of generated compressed fabric ID #9488

Merged
merged 2 commits into from
Sep 7, 2021

Conversation

pan-apple
Copy link
Contributor

Problem

The generated compressed fabric ID may be different for the same input for different platforms based on endianness.

Change overview

Convert generated compressed fabric ID to host system.

Testing

Added a new unit test that checks for generated compressed fabric ID against expected values for a given set of test inputs.

@github-actions
Copy link

github-actions bot commented Sep 5, 2021

Size increase report for "esp32-example-build" from 92309bc

File Section File VM
chip-lock-app.elf .flash.text 4 4
chip-bridge-app.elf .flash.text 4 4
chip-all-clusters-app.elf .flash.text 28 28
chip-shell.elf .flash.text 52 52
chip-temperature-measurement-app.elf .flash.text 36 36
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.debug_info,0,947
.debug_loc,0,386
.debug_line,0,269
.debug_ranges,0,208
.debug_abbrev,0,107
.debug_str,0,71
.flash.text,4,4
[Unmapped],0,-4

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.debug_info,0,929
.debug_loc,0,374
.debug_line,0,269
.debug_ranges,0,208
.debug_str,0,71
.flash.text,4,4
[Unmapped],0,-4
.debug_abbrev,0,-879

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,910
.debug_line,0,147
.debug_abbrev,0,107
.debug_loc,0,103
.debug_str,0,72
.flash.text,28,28
.debug_ranges,0,24
.debug_frame,0,4
.riscv.attributes,0,-3
[Unmapped],0,-28

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,894
.debug_loc,0,377
.debug_line,0,269
.debug_ranges,0,208
.debug_str,0,71
.flash.text,52,52
[Unmapped],0,-52
.debug_abbrev,0,-135

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.debug_info,0,925
.debug_loc,0,354
.debug_line,0,269
.debug_ranges,0,208
.debug_str,0,71
.flash.text,36,36
[Unmapped],0,-36
.debug_abbrev,0,-783


@todo
Copy link

todo bot commented Sep 7, 2021

- Optimize persistent storage of NOC and Root Cert in FabricInfo.

// TODO - Optimize persistent storage of NOC and Root Cert in FabricInfo.
CHIP_ERROR SetOperationalCertsFromCertArray(const chip::ByteSpan & certArray);
CHIP_ERROR SetRootCert(const chip::ByteSpan & cert);


This comment was generated by todo based on a TODO comment in 6c71631 in #9488. cc @pan-apple.

@woody-apple woody-apple merged commit 9b976c0 into project-chip:master Sep 7, 2021
@pan-apple pan-apple deleted the compressed-id-endianness branch September 7, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants