Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ota-requestor-app - initial set of changes of development branch #9474

Merged
merged 4 commits into from
Sep 14, 2021

Conversation

holbrookt
Copy link
Contributor

Problem

Submitting a work-in-progress ota-requestor-app so that others may begin to pick up development.

NOTE - this will not build successfully right now. See examples/ota-requestor-app/linux/README.md for the current state of this application.

Change overview

Add new example app ota-requestor-app.

Testing

N/A

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Size increase report for "esp32-example-build" from b2f134b

File Section File VM
chip-lock-app.elf .flash.text 64 64
chip-ipv6only-app.elf .flash.text 172 172
chip-temperature-measurement-app.elf .flash.text -36 -36
chip-shell.elf .flash.text -48 -48
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,64,64
.debug_loc,0,-4
.xt.lit._ZNK4chip4SpanIhE7SubSpanEjj,0,-8
.xt.prop._ZNK4chip4SpanIhE7SubSpanEjj,0,-12
[Unmapped],0,-64

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,3924
.flash.text,172,172

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,36
.flash.text,-36,-36

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,48
.flash.text,-48,-48

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize


@selissia selissia self-requested a review September 10, 2021 13:46
@andy31415 andy31415 changed the title WIP ota-requestor-app ota-requestor-app - initial set of changes of development branch Sep 14, 2021
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on SWTT developers working on OTA requests.

however comment says 'this app does not yet build' which is concerning - ideally we should check in code that at least compiles.

@andy31415
Copy link
Contributor

NOTE: Approved since OTA development team (@carol-apple , @selissia , @kkasperczyk-no ?) seemed to want this in.

The part in the readme that says 'code does not yet compile' is worrysome and wondering if it would maybe be better to not check in code that does not compile and instead have work proceed on a separate branch. My checkmark is more of a 'I trust OTA team to do the right thing'.

@holbrookt
Copy link
Contributor Author

NOTE: Approved since OTA development team (@carol-apple , @selissia , @kkasperczyk-no ?) seemed to want this in.

The part in the readme that says 'code does not yet compile' is worrysome and wondering if it would maybe be better to not check in code that does not compile and instead have work proceed on a separate branch. My checkmark is more of a 'I trust OTA team to do the right thing'.

I was asked by @woody-apple to submit whatever I currently had for the ota-requestor-app so that Carol and Sergei could get started helping out.

In any case, I am preparing a follow-up PR that will get this to build and run some minimal functionality ASAP.

@woody-apple woody-apple merged commit 1a333e0 into project-chip:master Sep 14, 2021
erjiaqing added a commit to erjiaqing/connectedhomeip that referenced this pull request Sep 15, 2021
Damian-Nordic pushed a commit that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants