-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ota-requestor-app - initial set of changes of development branch #9474
ota-requestor-app - initial set of changes of development branch #9474
Conversation
Size increase report for "esp32-example-build" from b2f134b
Full report output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on SWTT developers working on OTA requests.
however comment says 'this app does not yet build' which is concerning - ideally we should check in code that at least compiles.
NOTE: Approved since OTA development team (@carol-apple , @selissia , @kkasperczyk-no ?) seemed to want this in. The part in the readme that says 'code does not yet compile' is worrysome and wondering if it would maybe be better to not check in code that does not compile and instead have work proceed on a separate branch. My checkmark is more of a 'I trust OTA team to do the right thing'. |
I was asked by @woody-apple to submit whatever I currently had for the In any case, I am preparing a follow-up PR that will get this to build and run some minimal functionality ASAP. |
Problem
Submitting a work-in-progress ota-requestor-app so that others may begin to pick up development.
NOTE - this will not build successfully right now. See
examples/ota-requestor-app/linux/README.md
for the current state of this application.Change overview
Add new example app
ota-requestor-app
.Testing
N/A