Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K32W0 fixes: SRAM usage reduction, fix KVS factory reset #9449

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

doru91
Copy link
Contributor

@doru91 doru91 commented Sep 3, 2021

Problem

What is being fixed? Examples:

  • SRAM consumption was too high on K32W0
  • KVS bug that didn't erase all storage at factoryreset

Change overview

As described in #9261 several SRAM optimizations were needed:

  • decrease the number of Fabrics to 4 (from 16);
  • use OT MTD lib for the E-Lock App (which is an SED);
  • disable LWIP TCP/RAW/Debug/packet buffers.

Also, fix a bug in KVS where the deletion of some keys was not done properly.

Testing

  • manual testing

@merge-mamba
Copy link

merge-mamba bot commented Sep 3, 2021

Potential Conflict Warning

This pull request has changes that overlap with branches below. You might want to check in with the other
branch authors before you merge to avoid a conflict. 🐍

restyled/pull-9256 (@gjc13 @restyled-commits)

mdns-fixes (@chrisdecenzo)

restyled/pull-9310 (@tecimovic @restyled-commits)

Something wrong? Got a suggestion? Email me or leave feedback here.

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Size increase report for "esp32-example-build" from 53dd583

File Section File VM
chip-ipv6only-app.elf .flash.text 172 172
chip-temperature-measurement-app.elf .flash.text -36 -36
chip-bridge-app.elf .flash.text 48 48
chip-lock-app.elf .flash.text -64 -64
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,3924
.flash.text,172,172

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,36
.flash.text,-36,-36

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.flash.text,48,48
[Unmapped],0,-48

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,64
.xt.prop._ZNK4chip4SpanIhE7SubSpanEjj,0,12
.xt.lit._ZNK4chip4SpanIhE7SubSpanEjj,0,8
.debug_loc,0,-4
.flash.text,-64,-64

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


As described in project-chip#9261
several SRAM optimizations were needed:
* decrease the number of Fabrics to 4 (from 16);
* use OT MTD lib for the E-Lock App (which is an SED);
* disable LWIP TCP/RAW/Debug/packet buffers.

Also, fix a bug in KVS where the deletion of some keys was not done properly.

Signed-off-by: Doru Gucea <[email protected]>
@andy31415 andy31415 changed the title TE5 fixes K32W0 fixes: SRAM usage reduction, fix KVS factory reset Sep 3, 2021
@andy31415 andy31415 merged commit c688360 into project-chip:master Sep 3, 2021
andy31415 pushed a commit that referenced this pull request Sep 3, 2021
As described in #9261
several SRAM optimizations were needed:
* decrease the number of Fabrics to 4 (from 16);
* use OT MTD lib for the E-Lock App (which is an SED);
* disable LWIP TCP/RAW/Debug/packet buffers.

Also, fix a bug in KVS where the deletion of some keys was not done properly.

Signed-off-by: Doru Gucea <[email protected]>
@andy31415
Copy link
Contributor

Manually resolved conflict on TE5 cherrypick on src/platform/K32W/ThreadStackManagerImpl.cpp

@doru91 doru91 mentioned this pull request Sep 6, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
As described in project-chip#9261
several SRAM optimizations were needed:
* decrease the number of Fabrics to 4 (from 16);
* use OT MTD lib for the E-Lock App (which is an SED);
* disable LWIP TCP/RAW/Debug/packet buffers.

Also, fix a bug in KVS where the deletion of some keys was not done properly.

Signed-off-by: Doru Gucea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants