Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change temperature delta label to degrees Celsius #9427

Merged
merged 3 commits into from
Sep 13, 2021

Conversation

tewarid
Copy link
Contributor

@tewarid tewarid commented Sep 2, 2021

Problem

iOS Temperature Sensor screen shows Delta field with unit as F. Related to #9295.

Change overview

Change iOS Temperature Sensor screen Delta field label to degrees Celsius.

Testing

How was this tested?

  • Built with Xcode 12.5.1 and tested on iPhone with iOS 15 beta.

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Size increase report for "esp32-example-build" from f0ae9d8

File Section File VM
chip-temperature-measurement-app.elf .flash.text 32 32
chip-lock-app.elf .flash.text 68 68
chip-ipv6only-app.elf .flash.text 172 172
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,32,32
[Unmapped],0,-32

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,68,68
[Unmapped],0,-68

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,3924
.flash.text,172,172


@stale
Copy link

stale bot commented Sep 9, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Sep 9, 2021
@stale stale bot removed the stale Stale issue or PR label Sep 11, 2021
@andy31415
Copy link
Contributor

@andy31415 andy31415 merged commit f9de0af into project-chip:master Sep 13, 2021
@tewarid tewarid deleted the issue-9295 branch September 14, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants