Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Unauthenticated session #9401

Closed
wants to merge 3 commits into from
Closed

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Sep 1, 2021

A duplicate of #9269 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@restyled-io restyled-io bot added the restyled label Sep 1, 2021
@todo
Copy link

todo bot commented Sep 1, 2021

remove IsReliableTransmissionAllowed, this function should be provided over session.

// TODO: remove IsReliableTransmissionAllowed, this function should be provided over session.
virtual bool IsReliableTransmissionAllowed() const { return true; }
virtual bool IsEncryptionRequired() const { return true; }
};


This comment was generated by todo based on a TODO comment in 6b6567d in #9401. cc @project-chip.

@todo
Copy link

todo bot commented Sep 2, 2021

complete BLE address comparation

// TODO: complete BLE address comparation
return true;
}
return false;
}
static constexpr uint64_t kMinimalActivityTimeMs = 30000;
Time::TimeSource<Time::Source::kSystem> mTimeSource;
BitMapObjectPool<UnauthenticatedSession, kMaxConnectionCount> mEntries;
};


This comment was generated by todo based on a TODO comment in fee7323 in #9401. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-9269 branch from fee7323 to b7f0492 Compare September 2, 2021 09:25
@restyled-io restyled-io bot closed this Sep 2, 2021
@restyled-io restyled-io bot deleted the restyled/pull-9269 branch September 2, 2021 10:42
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this pull request Jul 9, 2024
- Address spec PRs project-chip#9305/project-chip#9401 re: removing gaps in
  attribute and command numbering.
- Introduce maturity level to everything.
mergify bot pushed a commit that referenced this pull request Jul 9, 2024
- Address spec PRs #9305/#9401 re: removing gaps in
  attribute and command numbering.
- Introduce maturity level to everything.
lazarkov pushed a commit to lazarkov/connectedhomeip that referenced this pull request Jul 10, 2024
…34261)

- Address spec PRs project-chip#9305/project-chip#9401 re: removing gaps in
  attribute and command numbering.
- Introduce maturity level to everything.
austina-csa pushed a commit to austina-csa/connectedhomeip that referenced this pull request Jul 10, 2024
…34261)

- Address spec PRs project-chip#9305/project-chip#9401 re: removing gaps in
  attribute and command numbering.
- Introduce maturity level to everything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants