Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Exit to the main screen after commissioning #9371

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

Damian-Nordic
Copy link
Contributor

Problem

Currently, Android CHIPTool automatically switches to the Light On/Off screen after commissioning a device
reglardless of its device type, which is not optimal for devices such as sensors.

Change overview

Exit to the main screen, instead, so a user may select a suitable screen to control a given device.

Testing

Tested manually with nRF Connect Lighting Example.

Damian-Nordic and others added 2 commits September 1, 2021 09:21
Currently, Android CHIPTool automatically switches to
the Light On/Off screen after commissioning a device
reglardless of its device type, which is not optimal
for devices such as sensors. Exit to the main screen,
instead, so a user may select a suitable screen.
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Size increase report for "esp32-example-build" from 2ccdcc1

File Section File VM
chip-lock-app.elf .flash.text -68 -68
chip-temperature-measurement-app.elf .flash.text 32 32
chip-ipv6only-app.elf .flash.text -172 -172
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,68
.flash.text,-68,-68

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,32,32
[Unmapped],0,-32

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
.flash.text,-172,-172
[Unmapped],0,-3924


@andy31415 andy31415 merged commit 5815350 into project-chip:master Sep 1, 2021
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Sep 24, 2021
)

* [android] Exit to the main screen after commissioning

Currently, Android CHIPTool automatically switches to
the Light On/Off screen after commissioning a device
reglardless of its device type, which is not optimal
for devices such as sensors. Exit to the main screen,
instead, so a user may select a suitable screen.

* Restyled by prettier-markdown

* Print a message on commissioning completion

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android documentation Improvements or additions to documentation review - approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants