-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] Exit to the main screen after commissioning #9371
Merged
andy31415
merged 3 commits into
project-chip:master
from
Damian-Nordic:android-main-screen
Sep 1, 2021
Merged
[android] Exit to the main screen after commissioning #9371
andy31415
merged 3 commits into
project-chip:master
from
Damian-Nordic:android-main-screen
Sep 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
android
documentation
Improvements or additions to documentation
labels
Aug 31, 2021
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jepenven-silabs,
LuDuda and
msandstedt
August 31, 2021 17:02
LuDuda
approved these changes
Aug 31, 2021
saurabhst
approved these changes
Aug 31, 2021
woody-apple
approved these changes
Aug 31, 2021
austinh0
approved these changes
Aug 31, 2021
src/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/CHIPToolActivity.kt
Show resolved
Hide resolved
yunhanw-google
approved these changes
Aug 31, 2021
msandstedt
approved these changes
Sep 1, 2021
Currently, Android CHIPTool automatically switches to the Light On/Off screen after commissioning a device reglardless of its device type, which is not optimal for devices such as sensors. Exit to the main screen, instead, so a user may select a suitable screen.
jmeg-sfy
approved these changes
Sep 1, 2021
Damian-Nordic
force-pushed
the
android-main-screen
branch
from
September 1, 2021 07:57
2f9f6d3
to
caa6cc7
Compare
Size increase report for "esp32-example-build" from 2ccdcc1
Full report output
|
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Sep 24, 2021
) * [android] Exit to the main screen after commissioning Currently, Android CHIPTool automatically switches to the Light On/Off screen after commissioning a device reglardless of its device type, which is not optimal for devices such as sensors. Exit to the main screen, instead, so a user may select a suitable screen. * Restyled by prettier-markdown * Print a message on commissioning completion Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, Android CHIPTool automatically switches to the Light On/Off screen after commissioning a device
reglardless of its device type, which is not optimal for devices such as sensors.
Change overview
Exit to the main screen, instead, so a user may select a suitable screen to control a given device.
Testing
Tested manually with nRF Connect Lighting Example.