Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Unauthenticated session #9365

Closed
wants to merge 3 commits into from
Closed

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Aug 31, 2021

A duplicate of #9269 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@restyled-io restyled-io bot added the restyled label Aug 31, 2021
@todo
Copy link

todo bot commented Aug 31, 2021

remove IsReliableTransmissionAllowed, this function should be provided over session.

// TODO: remove IsReliableTransmissionAllowed, this function should be provided over session.
virtual bool IsReliableTransmissionAllowed() const { return true; }
virtual bool IsEncryptionRequired() const { return true; }
};


This comment was generated by todo based on a TODO comment in 0ee2962 in #9365. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-9269 branch from 0ee2962 to 3c86412 Compare September 1, 2021 02:01
@merge-mamba
Copy link

merge-mamba bot commented Sep 1, 2021

Potential Conflict Warning

This pull request has changes that overlap with branches below. You might want to check in with the other
branch authors before you merge to avoid a conflict. 🐍

restyled/pull-9256 (@gjc13 @restyled-commits)

mdns-fixes (@chrisdecenzo)

Something wrong? Got a suggestion? Email me or leave feedback here.

1 similar comment
@merge-mamba
Copy link

merge-mamba bot commented Sep 1, 2021

Potential Conflict Warning

This pull request has changes that overlap with branches below. You might want to check in with the other
branch authors before you merge to avoid a conflict. 🐍

restyled/pull-9256 (@gjc13 @restyled-commits)

mdns-fixes (@chrisdecenzo)

Something wrong? Got a suggestion? Email me or leave feedback here.

@restyled-io restyled-io bot closed this Sep 1, 2021
@restyled-io restyled-io bot deleted the restyled/pull-9269 branch September 1, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants