Do not hardcode the UDP listen port in ChipDeviceController #9339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
pan-apple,
saurabhst and
woody-apple
tcarmelveilleux
approved these changes
Aug 30, 2021
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
andy31415
approved these changes
Aug 31, 2021
woody-apple
approved these changes
Aug 31, 2021
saurabhst
approved these changes
Aug 31, 2021
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Sep 24, 2021
…chip#9339) * Do not hardcode the UDP listen port in ChipDeviceController * Add the listen port to the init params * Update src/controller/CHIPDeviceController.h Co-authored-by: Tennessee Carmel-Veilleux <[email protected]> Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TLDR; Same PR as this #9309, but for the C++ library
ChipDeviceController hardcodes the UDP listen port to CHIP_PORT. This makes it impossible to have more than one instance of any of the controllers that use this on the same host.
The target device is unable to tell which one is which and messages arrive to both which results in communication failure.
Change overview
Do not hardcode the UDP listen port.
Testing
Tested pairing with two instances of the chip-tool cli with the same accessory.