Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused script build-all-clusters-app.py #9166

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

andy31415
Copy link
Contributor

Problem

build-all-clusters-app.py was meant for vscode build. It is not used anymore and build_examples.py is better in every way (can build more apps, does out of source build, has generate, is integrated in the vscode menu)(

Change overview

Remove obsolete script

Testing

Grepped inside the source tree for 'build-all-clusters-app' and found nothing.
Hoping nobody actually has this as a CLI flow, however if they do the switch to build_examples.py should be simple.

@github-actions
Copy link

Size increase report for "esp32-example-build" from 2abe1cf

File Section File VM
chip-temperature-measurement-app.elf .flash.text -64 -64
chip-bridge-app.elf .flash.text 48 48
chip-ipv6only-app.elf .flash.text -172 -172
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,64
.flash.text,-64,-64

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.flash.text,48,48
[Unmapped],0,-48

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,172
.flash.text,-172,-172


@woody-apple woody-apple merged commit 91688cc into project-chip:master Aug 21, 2021
sharadb-amazon pushed a commit to sharadb-amazon/connectedhomeip that referenced this pull request Aug 23, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@andy31415 andy31415 deleted the remove_script branch October 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants