-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start separating generated files in unique folder instead of inside the src/example tree #9124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d that regenall was a noop
order of includes is important here as the data model headersconnectedhomeip/src/app/chip_data_model.gni Lines 207 to 217 in dd801a6
This comment was generated by todo based on a
|
boring-cyborg
bot
added
documentation
Improvements or additions to documentation
examples
labels
Aug 19, 2021
tcarmelveilleux
approved these changes
Aug 20, 2021
mspang
approved these changes
Aug 20, 2021
mspang
reviewed
Aug 20, 2021
mspang
reviewed
Aug 20, 2021
mspang
approved these changes
Aug 20, 2021
Size increase report for "esp32-example-build" from 155d61f
Full report output
|
ghost
mentioned this pull request
Aug 23, 2021
sharadb-amazon
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Aug 23, 2021
…he src/example tree (project-chip#9124) * Start creating a zzz_generated folder * Allow output folder argument in zap generation python script. Verified that regenall was a noop * moved all generated files from examples into zzz_generated (by running regen-all) * Update gen folder as "zap-generated" * Rename gen to zap-generated in includes * More generated path renaming * update the cluster template generation to use the new zap-generated name * Rename more zap generated files * more renames and zapt updates. Fix build rule dependency * Add config dependency on data model: only need include paths * Fix include order. Lighting app on linux compiles * Add TODO regarding config path ordering * Prepare example generated files: nrf builds compile * Make lock app compile on nrf with the new directory structure * update telink makefile to match the new zap generated outputs * More compile logic updates * esp32 compiles now * Make the bridge app compile on esp32 * Exclude zap generated files from doxygen * Fix typo in CHIPCert, move the darwin header/mm files * Update a few more gen folder usages * Update java to zap-generated, move more files around * Restyle fixes * Update path inside pbxproj * Fix up lighting app cmake for mbed * Update lock generated files for esp32 lock app * Update paths for generated file for lock app cmakefiles * One more cmake fix for esp32 * Update CMakeLists.txt for the temperature measurement app * Add back af-gen-event.h even though they are NOT currently generated * Undo the data_model include logic * Move ota-provider-app to zzz_generated * Fix android build * Fix ota provider app build path for zap generated files * Restyle fixes * Fix up ota build * Updated fix for ota provider app build rules * Create ota-provider-app config globally, to fix up includes for common paths * Restyle fixes * Update relative paths into ota-provider-common to use top level include * Do not use relative path in includes in ota provider common
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…he src/example tree (project-chip#9124) * Start creating a zzz_generated folder * Allow output folder argument in zap generation python script. Verified that regenall was a noop * moved all generated files from examples into zzz_generated (by running regen-all) * Update gen folder as "zap-generated" * Rename gen to zap-generated in includes * More generated path renaming * update the cluster template generation to use the new zap-generated name * Rename more zap generated files * more renames and zapt updates. Fix build rule dependency * Add config dependency on data model: only need include paths * Fix include order. Lighting app on linux compiles * Add TODO regarding config path ordering * Prepare example generated files: nrf builds compile * Make lock app compile on nrf with the new directory structure * update telink makefile to match the new zap generated outputs * More compile logic updates * esp32 compiles now * Make the bridge app compile on esp32 * Exclude zap generated files from doxygen * Fix typo in CHIPCert, move the darwin header/mm files * Update a few more gen folder usages * Update java to zap-generated, move more files around * Restyle fixes * Update path inside pbxproj * Fix up lighting app cmake for mbed * Update lock generated files for esp32 lock app * Update paths for generated file for lock app cmakefiles * One more cmake fix for esp32 * Update CMakeLists.txt for the temperature measurement app * Add back af-gen-event.h even though they are NOT currently generated * Undo the data_model include logic * Move ota-provider-app to zzz_generated * Fix android build * Fix ota provider app build path for zap generated files * Restyle fixes * Fix up ota build * Updated fix for ota provider app build rules * Create ota-provider-app config globally, to fix up includes for common paths * Restyle fixes * Update relative paths into ota-provider-common to use top level include * Do not use relative path in includes in ota provider common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ZAP generated files are in-tree and this has undesired sideffects:
Change overview
<....>
includes instead of"..."
Testing
Verified that things build (except pump/pump-controller which does not build in ToT yet), CI will also validate things.
Checked that zap-regen-all does not change any output.