-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChipMdnsShutdown() #9108
Merged
woody-apple
merged 2 commits into
project-chip:master
from
kpschoedel:x8001-mdns-shutdown
Aug 19, 2021
Merged
Add ChipMdnsShutdown() #9108
woody-apple
merged 2 commits into
project-chip:master
from
kpschoedel:x8001-mdns-shutdown
Aug 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Issue project-chip#8001 MdnsAvahi destructor segfault; require separate shutdown MdnsAvahi can cause a crash on exit due to a static instance running code in its destructor after dependent components have shut down. #### Change overview - Add `ChipMdnsShutdown()`. This is a narrow fix, which does not attempt to address other potential problems with singleton mDNS state. - Fix TestMdns to shut down cleanly. #### Testing - TestMdns and CI.
kpschoedel
force-pushed
the
x8001-mdns-shutdown
branch
from
August 18, 2021 20:13
62131e0
to
f320b6f
Compare
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt,
shana-apple and
vivien-apple
August 18, 2021 20:17
msandstedt
approved these changes
Aug 18, 2021
Size increase report for "esp32-example-build" from 0bdeccb
Full report output
|
tcarmelveilleux
approved these changes
Aug 18, 2021
saurabhst
approved these changes
Aug 19, 2021
woody-apple
approved these changes
Aug 19, 2021
Merged
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Add ChipMdnsShutdown() #### Problem Issue project-chip#8001 MdnsAvahi destructor segfault; require separate shutdown MdnsAvahi can cause a crash on exit due to a static instance running code in its destructor after dependent components have shut down. #### Change overview - Add `ChipMdnsShutdown()`. This is a narrow fix, which does not attempt to address other potential problems with singleton mDNS state. - Fix TestMdns to shut down cleanly. #### Testing - TestMdns and CI. * restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue #8001 MdnsAvahi destructor segfault; require separate shutdown:
MdnsAvahi can cause a crash on exit due to a static instance running
code in its destructor after dependent components have shut down.
Change overview
ChipMdnsShutdown()
. This is a narrow fix, which does not attemptto address other potential problems with singleton mDNS state.
TestMdns
to shut down cleanly.Testing
TestMdns
and CI.