Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32: QEMU failure #9080

Closed
wants to merge 2 commits into from
Closed

Conversation

sweetymhaiske
Copy link
Contributor

Problem

What is being fixed? Examples:

Change overview

What's in this PR

Testing

How was this tested? (at least one bullet point required)

  • If unit tests were added, how do they cover this issue?
  • If unit tests existed, how were they fixed/modified to prevent this in future?
  • If new unit tests are not added, why not?
  • If integration tests were added, how do they verify this change?
  • If new integration tests are not added, why not?
  • If manually tested, what platforms controller and device platforms were manually tested, and how?
  • If no testing is required, why not?

@github-actions
Copy link

Size increase report for "esp32-example-build" from b0b53c8

File Section File VM
chip-bridge-app.elf .flash.text -48 -48
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
[Unmapped],0,48
.flash.text,-48,-48

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize


@sweetymhaiske sweetymhaiske force-pushed the qemu_fix branch 2 times, most recently from 0a0d805 to 95a662b Compare August 17, 2021 10:07
@sweetymhaiske sweetymhaiske force-pushed the qemu_fix branch 5 times, most recently from e2752ce to 79cd780 Compare August 17, 2021 11:54
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this pull request Aug 23, 2021
woody-apple pushed a commit that referenced this pull request Aug 23, 2021
* Make TestPubkey_x509Extraction build/run on ESP32 QEMU

Fixes #9075

* Fixed QEMU build based on #9080 suggestions
@tcarmelveilleux
Copy link
Contributor

Duplicate of #9077 now fixed. Closing. Thanks for helping resolve! For readers of posterity, the core thing that failed was: https://github.com/project-chip/connectedhomeip/pull/9080/files#diff-1a1f550b6c3ecd82d5963983f5cd2c368c05a825b706680653b7da0ddc694a5eR22 (a case-sensitive library prefix error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants