Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tizen OS port #8988

Merged
merged 14 commits into from
Sep 13, 2021
Merged

Add Tizen OS port #8988

merged 14 commits into from
Sep 13, 2021

Conversation

wootak-jung
Copy link
Contributor

@wootak-jung wootak-jung commented Aug 13, 2021

Problem
There is no Support for Tizen OS on Matter

Change overview
Adding Support for Tizen OS on Matter along with Lighting app example

Supported WiFi and BLE and Mdns connectivity.
(The implementation of the function will be updated sequentially.)
There is only one examples in this PR: The lighting application.

Testing
How was this tested? (at least one bullet point required)

  • If new unit tests are not added, why not?

Unit tests are not support as of now and will be covered as part of next release update

  • If new integration tests are not added, why not?

Integration and CI build support will be added as part of next update

Build command

  • Install tizen sdk:
$ export TIZEN_HOME=$HOME/tizen_sdk
$ mkdir -p $TIZEN_HOME
$ ./config/tizen/scripts/install_sdk.sh $TIZEN_HOME
  • Build the Lighting app example:
$ ./scripts/run_in_build_env.sh "./scripts/build/build_examples.py --platform tizen build"

@MoonkiHong
Copy link

On progress: Tizen Docker image is being registered into DockerHub. Once it is completed, we can see the https://github.com/project-chip/connectedhomeip/pull/8988/checks?check_run_id=3319802487. Thank you in advance for your kind patience.

.vscode/tasks.json Outdated Show resolved Hide resolved
@andy31415
Copy link
Contributor

It looks like the dockerfile for tizen uses custom users and this causes:

Deleting the contents of '/__w/connectedhomeip/connectedhomeip'
Initializing the repository
  /usr/bin/git init /__w/connectedhomeip/connectedhomeip
  /__w/connectedhomeip/connectedhomeip/.git: Permission denied
  Error: The process '/usr/bin/git' failed with exit code 1

@wootak-jung
Copy link
Contributor Author

It looks like the dockerfile for tizen uses custom users and this causes:

Deleting the contents of '/__w/connectedhomeip/connectedhomeip'
Initializing the repository
  /usr/bin/git init /__w/connectedhomeip/connectedhomeip
  /__w/connectedhomeip/connectedhomeip/.git: Permission denied
  Error: The process '/usr/bin/git' failed with exit code 1

I added following option in yaml file.
options: --user root

@wootak-jung
Copy link
Contributor Author

@andy31415 Hello Andy,
I fixed the workflow action error. Could you re-run the workflow again?

@wootak-jung
Copy link
Contributor Author

@andy31415 Hello Andy,
I resolved the code conflicts. please re-run workflows.
Thank you.

@wootak-jung wootak-jung requested a review from andy31415 August 19, 2021 23:29
@MoonkiHong
Copy link

@andy31415 Hi, Andy. Workflow seems to be run one time everyday, and unfortunately, this PR has been blocked by every CI process due to the consistent influx of other PRs. 😭 We have consistently updated our code everyday for this PR after this CI failure, especially in order to resolve the merge conflict. How can we go forward? We understand that you are super busy and need to review a lot of PRs, but if possible and as @wootak-jung has requested, could you re-run the workflow shortly? Thank you in advance. 🙏

@msandstedt @saurabhst Please take a look at this PR. 😄 We need your guidance. (also cc-ed @electrocucaracha)

@electrocucaracha
Copy link
Collaborator

I just wonder if this requires to /rebase

@msandstedt
Copy link
Contributor

@msandstedt @saurabhst Please take a look at this PR. 😄 We need your guidance. (also cc-ed @electrocucaracha)

The CI has automation (pullapprove) to add all reviewers, so we want to trigger that. This will be triggered once restyled passes, so that's what we need to fix.

To make this happen, run this locally and commit and push up the diff:

./scripts/helpers/restyle-diff.sh dedc71bce55e0a0cfcaa3288dfd7c43dbae69a04

dedc71b is the current rev from master that the branch is based on.

@wootak-jung
Copy link
Contributor Author

wootak-jung commented Aug 20, 2021

@msandstedt I applied the restyle script. Please re-run actions. Thank you.

build/config/compiler/BUILD.gn Outdated Show resolved Hide resolved
build_overrides/tizen.gni Outdated Show resolved Hide resolved
config/tizen/chip-gn/platform/BUILD.gn Outdated Show resolved Hide resolved
examples/build_overrides/tizen.gni Outdated Show resolved Hide resolved
scripts/build/builders/tizen.py Outdated Show resolved Hide resolved
@erjiaqing
Copy link
Contributor

erjiaqing commented Aug 31, 2021

#9352 PR filed for sysroot support in pkg-config.

@wootak-jung
Copy link
Contributor Author

@mspang @andy31415 Please review and reply our previous comments.

@wootak-jung
Copy link
Contributor Author

@erjiaqing @mspang I removed env setting logic based on #9352. please review. Thank you.

@github-actions
Copy link

Size increase report for "esp32-example-build" from aea81e3

File Section File VM
chip-shell.elf .flash.text 43 48
chip-temperature-measurement-app.elf .flash.text -32 -32
chip-ipv6only-app.elf .flash.text -172 -172
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,4053
.flash.text,48,43

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,32
.flash.text,-32,-32

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
.flash.text,-172,-172
[Unmapped],0,-3924

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants