Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move keeping track of encoding to codec a la TLV #898

Merged
merged 4 commits into from
May 28, 2020
Merged

move keeping track of encoding to codec a la TLV #898

merged 4 commits into from
May 28, 2020

Conversation

rwalker-apple
Copy link
Contributor

Problem

chipZclBuffer manages read/write cursor, which is more job than we need, and doesn't map onto PacketBuffers

Summary of Changes

  • hoist the cursor into the codec (which parallels TLVWriter/Reader)
  • check for null

is step 3 in #657
step 4 in #657 is to make chipZclBuffer opaque

@rwalker-apple rwalker-apple force-pushed the move-keeping-track-of-encoding-to-codec-a-la-TLV branch from a530b4b to 73c653e Compare May 28, 2020 21:11
@rwalker-apple rwalker-apple force-pushed the move-keeping-track-of-encoding-to-codec-a-la-TLV branch from 73c653e to f8679d5 Compare May 28, 2020 21:14
@rwalker-apple rwalker-apple mentioned this pull request May 28, 2020
Merged
@rwalker-apple
Copy link
Contributor Author

@bzbarsky-apple @bhaskar-apple @tecimovic interested in any feedback

@rwalker-apple rwalker-apple force-pushed the move-keeping-track-of-encoding-to-codec-a-la-TLV branch from e5f9ca9 to 8df05ef Compare May 28, 2020 22:14
@woody-apple woody-apple merged commit ef2b681 into project-chip:master May 28, 2020
@rwalker-apple rwalker-apple deleted the move-keeping-track-of-encoding-to-codec-a-la-TLV branch May 28, 2020 22:31
rerasool pushed a commit to SiliconLabs/matter that referenced this pull request Jun 23, 2023
@jmartinez-silabs
Pull request project-chip#898: Update submodules for gecko_sdk 4.2.3 …
1a1435c 
…and matter_support for generated board configs, update efr32_sdk.gni to match gen files.

Merge in WMN_TOOLS/matter from Gsdk4.2.3_update_2.1.0-1.1 to RC_2.1.0-1.1

Squashed commit of the following:

commit bbbb38f3913607e3b171cff35c933f515cf096e1
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 22:34:42 2023 -0400

    fem util cleanup

commit f9b8ebb61cd3f6a56e44b3e0b31ecd34b51aa25f
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:53:34 2023 -0400

    matter_support points to new main commit

commit 2e292e959b4c23eaf9635680599b5d8eb4215456
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:20:49 2023 -0400

    fix brd4319A

... and 7 more commits
jmartinez-silabs added a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Jul 4, 2023
@jmartinez-silabs
Pull request project-chip#898: Update submodules for gecko_sdk 4.2.3 …
dae4d20 
…and matter_support for generated board configs, update efr32_sdk.gni to match gen files.

Merge in WMN_TOOLS/matter from Gsdk4.2.3_update_2.1.0-1.1 to RC_2.1.0-1.1

Squashed commit of the following:

commit bbbb38f3913607e3b171cff35c933f515cf096e1
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 22:34:42 2023 -0400

    fem util cleanup

commit f9b8ebb61cd3f6a56e44b3e0b31ecd34b51aa25f
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:53:34 2023 -0400

    matter_support points to new main commit

commit 2e292e959b4c23eaf9635680599b5d8eb4215456
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:20:49 2023 -0400

    fix brd4319A

... and 7 more commits
jmartinez-silabs added a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Jul 5, 2023
@jmartinez-silabs
Pull request project-chip#898: Update submodules for gecko_sdk 4.2.3 …
779db26 
…and matter_support for generated board configs, update efr32_sdk.gni to match gen files.

Merge in WMN_TOOLS/matter from Gsdk4.2.3_update_2.1.0-1.1 to RC_2.1.0-1.1

Squashed commit of the following:

commit bbbb38f3913607e3b171cff35c933f515cf096e1
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 22:34:42 2023 -0400

    fem util cleanup

commit f9b8ebb61cd3f6a56e44b3e0b31ecd34b51aa25f
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:53:34 2023 -0400

    matter_support points to new main commit

commit 2e292e959b4c23eaf9635680599b5d8eb4215456
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:20:49 2023 -0400

    fix brd4319A

... and 7 more commits
jmartinez-silabs added a commit to jmartinez-silabs/connectedhomeip that referenced this pull request Jul 5, 2023
@jmartinez-silabs
Pull request project-chip#898: Update submodules for gecko_sdk 4.2.3 …
26539df 
…and matter_support for generated board configs, update efr32_sdk.gni to match gen files.

Merge in WMN_TOOLS/matter from Gsdk4.2.3_update_2.1.0-1.1 to RC_2.1.0-1.1

Squashed commit of the following:

commit bbbb38f3913607e3b171cff35c933f515cf096e1
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 22:34:42 2023 -0400

    fem util cleanup

commit f9b8ebb61cd3f6a56e44b3e0b31ecd34b51aa25f
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:53:34 2023 -0400

    matter_support points to new main commit

commit 2e292e959b4c23eaf9635680599b5d8eb4215456
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:20:49 2023 -0400

    fix brd4319A

... and 7 more commits
andy31415 pushed a commit that referenced this pull request Jul 6, 2023
@jmartinez-silabs @restyled-commits
[Silabs ]Update to GSDK 4.2.3 (#27618)
c747f54 
* Pull request #898: Update submodules for gecko_sdk 4.2.3 and matter_support for generated board configs, update efr32_sdk.gni to match gen files.

Merge in WMN_TOOLS/matter from Gsdk4.2.3_update_2.1.0-1.1 to RC_2.1.0-1.1

Squashed commit of the following:

commit bbbb38f3913607e3b171cff35c933f515cf096e1
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 22:34:42 2023 -0400

    fem util cleanup

commit f9b8ebb61cd3f6a56e44b3e0b31ecd34b51aa25f
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:53:34 2023 -0400

    matter_support points to new main commit

commit 2e292e959b4c23eaf9635680599b5d8eb4215456
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:20:49 2023 -0400

    fix brd4319A

... and 7 more commits

* Pull request #903: Fix system time counter

Merge in WMN_TOOLS/matter from fix/time_drift to RC_2.1.0-1.1

Squashed commit of the following:

commit e34404ff67f6c1219ef4cbf39e64fc2cc4084870
Author: Satya Naag Bollimpalli <[email protected]>
Date:   Wed Jun 21 11:02:30 2023 +0000

    Pull request #904: changing the unify git location from cph to stash

    Merge in WMN_TOOLS/matter from bugfix/matter-bridge-jenkins-unify-git-location-change to silabs_1.1

    Squashed commit of the following:

    commit 0b9db3c60485b21fbabcb6f592ea09ba8c1b6c36
    Author: sabollim <[email protected]>
    Date:   Wed Jun 21 09:45:37 2023 +0530

        changing the unify git location from bitbucket-cph to stash

    commit 0859339d2bf0f20ea0bb5acded2fd3b7459c10d8
    Author: sabollim <[email protected]>
    Date:   Wed Jun 21 09:24:07 2023 +0530

        changing the unify git location from cph to stash

commit 63dfc3f438d416645a07878859b8886ba6a3eafb
Author: Junior Martinez <[email protected]>
Date:   Tue Jun 20 21:27:25 2023 -0400

    update matter_support submodule hash

commit 889cfb413e47452e09c03b7b0ba88da313738a7a
Author: Junior Martinez <[email protected]>
Date:   Tue Jun 20 20:01:40 2023 -0400

    Always build tick_power_manager.c has we now how sleeptimer and power manager always on. Fix paths for segger system view debugging

Pull request #907: [Silabs][Wf200] Disabling sleep

Merge in WMN_TOOLS/matter from bugfix/wf200_sleep to RC_2.1.0-1.1

Squashed commit of the following:

commit c14edfc41dd9e8427fd242f3fcd3055043cb33ec
Author: Chirag Bansal <[email protected]>
Date:   Thu Jun 22 11:24:49 2023 +0530

    changing the condition so that wf200 doesn't go in sleep by default

commit 694226bfb43e8fdfe0e2bb16fd8570bb740aec07
Author: Jean-Francois Penven <[email protected]>
Date:   Mon May 29 10:11:02 2023 -0400

    Fix matter shell with wf200 (#26845)

* Restyled by whitespace

* Restyled by clang-format

* pull new docker image for chip-build-efr32

---------

Co-authored-by: Restyled.io <[email protected]>
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@jmartinez-silabs
Pull request project-chip#898: Update submodules for gecko_sdk 4.2.3 …
cc06d82 
…and matter_support for generated board configs, update efr32_sdk.gni to match gen files.

Merge in WMN_TOOLS/matter from Gsdk4.2.3_update_2.1.0-1.1 to RC_2.1.0-1.1

Squashed commit of the following:

commit bbbb38f3913607e3b171cff35c933f515cf096e1
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 22:34:42 2023 -0400

    fem util cleanup

commit f9b8ebb61cd3f6a56e44b3e0b31ecd34b51aa25f
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:53:34 2023 -0400

    matter_support points to new main commit

commit 2e292e959b4c23eaf9635680599b5d8eb4215456
Author: Junior Martinez <[email protected]>
Date:   Mon Jun 19 20:20:49 2023 -0400

    fix brd4319A

... and 7 more commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@gerickson gerickson gerickson approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwalker-apple @gerickson @saurabhst @woody-apple