Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shutting down System::Layer in unit tests #8865

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Fix shutting down System::Layer in unit tests #8865

merged 2 commits into from
Aug 11, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

Some unit tests either reference System::Layer after its destruction,
or don't call Shutdown before its destruction.

Change overview

  • Shut down System::Layer in test finalization
  • Don't initialize System::Layer repeatedly (although this is currently
    harmless).
  • Separate IOContext, which uses a ‘hidden’ global System::Layer via
    NetworkTestHelpers, from Test::MessagingContext, which is sometimes
    multiply instantiated.

Testing

Quis custodiet ipsos custodes?

@kpschoedel
Fix shutting down System::Layer in unit tests
e1a8637 
#### Problem

Some unit tests either reference System::Layer after its destruction,
or don't call Shutdown before its destruction.

#### Change overview

- Shut down System::Layer in test finalization
- Don't initialize System::Layer repeatedly (although this is currently
  harmless).
- Separate IOContext, which uses a ‘hidden’ global System::Layer via
  NetworkTestHelpers, from Test::MessagingContext, which is sometimes
  multiply instantiated.

#### Testing

Quis custodiet ipsos custodes?
@restyled-io restyled-io bot mentioned this pull request Aug 9, 2021
Closed
@woody-apple woody-apple merged commit b3f7d9f into project-chip:master Aug 11, 2021
@kpschoedel kpschoedel deleted the test-shutdown branch August 11, 2021 13:11
This was referenced Aug 13, 2021
Merged
Closed
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Aug 25, 2021
@kpschoedel
Check and fix System::Layer shutdown sequencing
ad1d255 
#### Problem

There have been multiple instances of code using a `System::Layer`
object after it has been shut down or destroyed (some previously
fixed in project-chip#8865). In the ancestral code, `System::Layer` was fully
static, so this ‘worked’.

#### Change overview

- More thoroughly track and check `System::Layer` object state.
- Spin out state tracking into `lib/support/ObjectLifeCycle.h`
- Fix several sequencing issues.

#### Testing

CI; no change to visible functionality intended.
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Aug 25, 2021
@kpschoedel
Check and fix System::Layer shutdown sequencing
aa6e189 
#### Problem

There have been multiple instances of code using a `System::Layer`
object after it has been shut down or destroyed, some previously
fixed in project-chip#8865. (In the ancestral code, `System::Layer` was fully
static.)

#### Change overview

- More thoroughly track and check `System::Layer` object state.
- Spin out state tracking into `lib/support/ObjectLifeCycle.h`
- Fix several sequencing issues.

#### Testing

CI; no change to visible functionality intended.
@kpschoedel kpschoedel mentioned this pull request Aug 25, 2021
Merged
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Aug 27, 2021
@kpschoedel
Check and fix System::Layer shutdown sequencing
f1d1487 
#### Problem

There have been multiple instances of code using a `System::Layer`
object after it has been shut down or destroyed, some previously
fixed in project-chip#8865. (In the ancestral code, `System::Layer` was fully
static.)

#### Change overview

- More thoroughly track and check `System::Layer` object state.
- Spin out state tracking into `lib/support/ObjectLifeCycle.h`
- Fix several sequencing issues.

#### Testing

CI; no change to visible functionality intended.
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Aug 30, 2021
@kpschoedel
Check and fix System::Layer shutdown sequencing
fc87fb5 
#### Problem

There have been multiple instances of code using a `System::Layer`
object after it has been shut down or destroyed, some previously
fixed in project-chip#8865. (In the ancestral code, `System::Layer` was fully
static.)

#### Change overview

- More thoroughly track and check `System::Layer` object state.
- Spin out state tracking into `lib/support/ObjectLifeCycle.h`
- Fix several sequencing issues.

#### Testing

CI; no change to visible functionality intended.
mspang pushed a commit that referenced this pull request Aug 31, 2021
@kpschoedel
Check and fix System::Layer shutdown sequencing (#9247)
371fb31 
#### Problem

There have been multiple instances of code using a `System::Layer`
object after it has been shut down or destroyed, some previously
fixed in #8865. (In the ancestral code, `System::Layer` was fully
static.)

#### Change overview

- More thoroughly track and check `System::Layer` object state.
- Spin out state tracking into `lib/support/ObjectLifeCycle.h`
- Fix several sequencing issues.

#### Testing

CI; no change to visible functionality intended.
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@kpschoedel
Fix shutting down System::Layer in unit tests (project-chip#8865)
c839cfd 
* Fix shutting down System::Layer in unit tests

#### Problem

Some unit tests either reference System::Layer after its destruction,
or don't call Shutdown before its destruction.

#### Change overview

- Shut down System::Layer in test finalization
- Don't initialize System::Layer repeatedly (although this is currently
  harmless).
- Separate IOContext, which uses a ‘hidden’ global System::Layer via
  NetworkTestHelpers, from Test::MessagingContext, which is sometimes
  multiply instantiated.

#### Testing

Quis custodiet ipsos custodes?

* restyle
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Sep 24, 2021
@kpschoedel @mkardous-silabs
Check and fix System::Layer shutdown sequencing (project-chip#9247)
54ff9ca 
#### Problem

There have been multiple instances of code using a `System::Layer`
object after it has been shut down or destroyed, some previously
fixed in project-chip#8865. (In the ancestral code, `System::Layer` was fully
static.)

#### Change overview

- More thoroughly track and check `System::Layer` object state.
- Spin out state tracking into `lib/support/ObjectLifeCycle.h`
- Fix several sequencing issues.

#### Testing

CI; no change to visible functionality intended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kedars kedars Awaiting requested review from kedars

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
app review - pending transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpschoedel @woody-apple @bzbarsky-apple @Damian-Nordic