Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZAP] Add a script to update .zap files automatically #8806

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

When third_party/zap/repo is updated, or when some of the definitions from src/app/zap-templates/data-model/ are updated, the .zap files needs to be changed accordingly. There is a zap-script for it, but it has not been used much.

In order to make it easier to use, this PR add a script ./scripts/tools/zap_convert_all.py that converts all files using scripts/tools/zap/convert.py

Change overview

  • Add scripts/tools/zap_convert_all.py
  • Add scripts/tools/zap/convert.py
  • Run scripts/tools/zap_convert_all.py and commit the changes

Testing

  • The generated code has not changed (after running zap_regen_all.py, as such the output binary are not changes.

@vivien-apple vivien-apple force-pushed the ZAP_AddConvertScript branch from 50545a6 to 7aa567f Compare August 5, 2021 18:26
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

Size increase report for "esp32-example-build" from 6b6c2ee

File Section File VM
chip-lock-app.elf .flash.text 64 64
chip-all-clusters-app.elf .flash.text -80 -80
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,64,64
[Unmapped],0,-64

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,80
.flash.text,-80,-80

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


@bzbarsky-apple bzbarsky-apple merged commit 815a855 into project-chip:master Aug 6, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
)

* [ZAP] Add a script to update .zap files automatically

* Update zap files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants