-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CHIP_ERROR a class type on nrfconnect #8652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Having CHIP_ERROR be a class type would provide (a) type safety, and (b) the ability to trace the source of errors (issue project-chip#8340). #### Change overview - Enable `CHIP_CONFIG_ERROR_CLASS` on nrfconnect. #### Testing Existing tests should confirm no change to functionality.
kpschoedel
force-pushed
the
x8340-error-class-4
branch
from
July 28, 2021 01:46
c0f44aa
to
cb32df2
Compare
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
vivien-apple
July 28, 2021 01:46
Size increase report for "esp32-example-build" from 5da31a9
Full report output
|
Size increase report for "nrfconnect-example-build" from 5da31a9
Full report output
|
bzbarsky-apple
approved these changes
Jul 28, 2021
msandstedt
approved these changes
Jul 28, 2021
Damian-Nordic
approved these changes
Jul 28, 2021
saurabhst
approved these changes
Jul 28, 2021
mspang
approved these changes
Jul 28, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
#### Problem Having CHIP_ERROR be a class type would provide (a) type safety, and (b) the ability to trace the source of errors (issue project-chip#8340). #### Change overview - Enable `CHIP_CONFIG_ERROR_CLASS` on nrfconnect. #### Testing Existing tests should confirm no change to functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Having CHIP_ERROR be a class type would provide (a) type safety,
and (b) the ability to trace the source of errors (issue #8340).
Recent changes have made CHIP_ERROR a class on Linux (#8383),
cc13x2_26x2, EFR32, QPG (#8446), and ESP32 (#8469).
Change overview
CHIP_CONFIG_ERROR_CLASS
on nrfconnect.Testing
Existing tests should confirm no change to functionality.