Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CHIP_ERROR a class type on nrfconnect #8652

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

Having CHIP_ERROR be a class type would provide (a) type safety,
and (b) the ability to trace the source of errors (issue #8340).

Recent changes have made CHIP_ERROR a class on Linux (#8383),
cc13x2_26x2, EFR32, QPG (#8446), and ESP32 (#8469).

Change overview

  • Enable CHIP_CONFIG_ERROR_CLASS on nrfconnect.

Testing

Existing tests should confirm no change to functionality.

#### Problem

Having CHIP_ERROR be a class type would provide (a) type safety,
and (b) the ability to trace the source of errors (issue project-chip#8340).

#### Change overview

- Enable `CHIP_CONFIG_ERROR_CLASS` on nrfconnect.

#### Testing

Existing tests should confirm no change to functionality.
@github-actions
Copy link

Size increase report for "esp32-example-build" from 5da31a9

File Section File VM
chip-lock-app.elf .flash.text 64 64
chip-ipv6only-app.elf .flash.text -172 -172
chip-shell.elf .flash.text 20 20
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,64,64
[Unmapped],0,-64

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,172
.flash.text,-172,-172

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.flash.text,20,20
[Unmapped],0,-20

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 5da31a9

File Section File VM
chip-shell.elf device_handles -12 -12
chip-shell.elf text -84 -84
chip-lock.elf device_handles -4 -4
chip-lock.elf text -12 -12
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,42560
.debug_loc,0,18974
.debug_line,0,11697
.debug_abbrev,0,1495
.debug_ranges,0,1432
.debug_str,0,894
.strtab,0,594
.debug_aranges,0,16
.symtab,0,16
.shstrtab,0,2
device_handles,-12,-12
text,-84,-84
.debug_frame,0,-164

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,96960
.debug_loc,0,50255
.debug_line,0,29630
.debug_abbrev,0,2810
.debug_ranges,0,2648
.debug_str,0,1349
.strtab,0,938
.symtab,0,32
.debug_aranges,0,24
.shstrtab,0,-2
device_handles,-4,-4
text,-12,-12
.debug_frame,0,-388


@mspang mspang merged commit fcbe2e0 into project-chip:master Jul 28, 2021
@kpschoedel kpschoedel deleted the x8340-error-class-4 branch July 28, 2021 13:16
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
#### Problem

Having CHIP_ERROR be a class type would provide (a) type safety,
and (b) the ability to trace the source of errors (issue project-chip#8340).

#### Change overview

- Enable `CHIP_CONFIG_ERROR_CLASS` on nrfconnect.

#### Testing

Existing tests should confirm no change to functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants