Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop redefining CHIP_ERROR in Darwin headers. #8576

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

That gets in the way of making it a class on Darwin.

Problem

Darwin headers redefine CHIP_ERROR, which makes it hard to turn on CHIP_CONFIG_ERROR_CLASS.

Change overview

Remove the CHIP_ERROR redefinition.

Testing

Compiled iOS CHIPTool, ran Darwin tests locally.

That gets in the way of making it a class on Darwin.
@github-actions
Copy link

Size increase report for "esp32-example-build" from c4fe313

File Section File VM
chip-ipv6only-app.elf .flash.text 172 172
chip-shell.elf .flash.text 32 32
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
.flash.text,172,172
[Unmapped],0,-172

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.flash.text,32,32
[Unmapped],0,-32


@bzbarsky-apple
Copy link
Contributor Author

@mspang @LuDuda @Damian-Nordic @msandstedt @saurabhst @jepenven-silabs @jmartinez-silabs @jelderton @woody-apple Please take a look? This is one of the few things keeping us from turning on CHIP_ERROR-as-class on Darwin.

@woody-apple woody-apple merged commit f382df3 into project-chip:master Jul 22, 2021
@bzbarsky-apple bzbarsky-apple deleted the no-more-error-redefine branch July 22, 2021 22:14
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
That gets in the way of making it a class on Darwin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants