Looks like the changes to other clusters didn't make it to the #8523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bzbarsky-apple
approved these changes
Jul 20, 2021
thermostat cluster. These changes allow it to compile again
drempelg
force-pushed
the
thermostat_fixup
branch
from
55ba17a to
e3b177c
Compare
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang and
saurabhst
saurabhst
approved these changes
Jul 20, 2021
jmartinez-silabs
approved these changes
Jul 21, 2021
alexhqwang
added a commit
to alexhqwang/connectedhomeip
that referenced
this pull request
Sep 1, 2021
Specific commits needed for Zirconium: * 09c8dd09 Looks like the changes to other clusters didn't make it to the (project-chip#8523) * e6860d13 Change QR code payload setup to use C strings (project-chip#8526) Issue: b/194314482 Change-Id: I9969de2120e23f00f458892bc8366a4487901eb5
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…ct-chip#8523) * Looks like the changes to other clusters didn't make it to the thermostat cluster. These changes allow it to compile again * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thermostat cluster. These changes allow it to compile again
Problem
When including this source file in a project that uses the matter SDK this file fails to compile. Looks like it's been overlooked in some recent refactors.
Change overview
Fixed up location of headers that are being included, fixed up the function signatures to match the signatures generated by zap, and initialized the status variable since that was also triggering a compiler failure on our project.
Testing
Not functionally tested as there were no functional changes. This is purely to get things compiling once again.
Tested compiling using our devices project.