[Android] Rename onOpCSRGenerationComplete() parameter #8522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
jlportillo,
msandstedt,
pan-apple and
yufengwangca
jlportillo
approved these changes
Jul 20, 2021
yufengwangca
approved these changes
Jul 20, 2021
msandstedt
approved these changes
Jul 20, 2021
src/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/GenericChipDeviceListener.kt
Show resolved
Hide resolved
Damian-Nordic
approved these changes
Jul 21, 2021
andy31415
pushed a commit
that referenced
this pull request
Jul 26, 2021
* Initial creation of thermostat dev testing app * Added stubbed in support for low power needed for rebase * Added optional attributes to thermostat.zap for scheduling * Added Thermostat cluster scheduling attributes * Regenerate files after controller.zap file changes * Restyled by gn * errorcode -> csr (#8522) * Initial creation of thermostat dev testing app * Added stubbed in support for low power needed for rebase * Added optional attributes to thermostat.zap for scheduling * Added Thermostat cluster scheduling attributes * Regenerate files after controller.zap file changes * Restyled by gn * Adding Thermostat Attributes for scheduling to the all clusters zap to pass darwin test * regen all files Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Austin Hsieh <[email protected]>
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…hip#8540) * Initial creation of thermostat dev testing app * Added stubbed in support for low power needed for rebase * Added optional attributes to thermostat.zap for scheduling * Added Thermostat cluster scheduling attributes * Regenerate files after controller.zap file changes * Restyled by gn * errorcode -> csr (project-chip#8522) * Initial creation of thermostat dev testing app * Added stubbed in support for low power needed for rebase * Added optional attributes to thermostat.zap for scheduling * Added Thermostat cluster scheduling attributes * Regenerate files after controller.zap file changes * Restyled by gn * Adding Thermostat Attributes for scheduling to the all clusters zap to pass darwin test * regen all files Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Austin Hsieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
errorCode.Change overview
errorCodetocsr.Testing