-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial pybind11 Controller Wrapper #8428
Conversation
d188e03
to
b5c952c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bindings here seem fine to me, thanks for trimming it down.
It might a bit overkill to generate exception types for every error code, but I can see why this might be useful. (e.g. python doesn't do that for 'errno' - OSError is a single type)
effe009
to
6d45518
Compare
Approved based on offline sync: goal is to wrap minimally-needed (where minimal may not be small) for CSG and we plan to use binder as a starting point, however long term support will involve manually maintaining the files and adding wrappers if needed because of architecture/C++ feature needs. |
Some things are still broken about this, such as the PEP 425 tagging and the header paths, but it shouldn't do anyone any harm to fix those issue in a later change. |
/rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes due to some changes looking like a revert
6f2fbe3
to
ddba1c0
Compare
15d2556
to
f0d8760
Compare
CHIP_ERROR update from Kevin Fixes small errors in create_error_wrapper based off the new CHIPError class Fixing darin workflow to install python3.9 Adding full path to gitmodules
f0d8760
to
9bee5f6
Compare
Log Upload #2227connectedhomeip/.github/workflows/build.yaml Lines 226 to 236 in 9bee5f6
This comment was generated by todo based on a
|
#1512connectedhomeip/.github/workflows/build.yaml Lines 227 to 237 in 9bee5f6
This comment was generated by todo based on a
|
Size increase report for "esp32-example-build" from 515ea65
Full report output
|
CHIP_ERROR update from Kevin Fixes small errors in create_error_wrapper based off the new CHIPError class Fixing darin workflow to install python3.9 Adding full path to gitmodules
Problem
Change overview
Testing