Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CHIP shell NFC commands compilation failure #8365

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

kkasperczyk-no
Copy link
Contributor

Problem

The CHIP shell command handlers API changed and methods should return CHIP_ERROR instead of int. NFC commands file was not aligned and compilation for it fails.

Change overview

Changed NFCHandler to return CHIP_ERROR instead of int.

Testing

Verified that after change build for NFC.cpp file passes.

The CHIP shell command handlers API changed and methods should
return CHIP_ERROR instead of int. NFC commands file was not aligned
and compilation for it fails.

Changed NFCHandler to return CHIP_ERROR instead of int.
@github-actions
Copy link

Size increase report for "esp32-example-build" from c76a376

File Section File VM
chip-temperature-measurement-app.elf .flash.text 60 60
chip-lock-app.elf .flash.text -64 -64
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,60,60
[Unmapped],0,-60

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,64
.flash.text,-64,-64


@andy31415 andy31415 merged commit f82b820 into project-chip:master Jul 14, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
The CHIP shell command handlers API changed and methods should
return CHIP_ERROR instead of int. NFC commands file was not aligned
and compilation for it fails.

Changed NFCHandler to return CHIP_ERROR instead of int.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants