Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bloat check workflow concurrency #8189

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

We have not had a completed bloat check in 13 hours; new ones keep canceling old ones.

Change overview

Make new bloat checks not cancel old ones, at least if the old ones are running already.

Testing

Will see if it helps when it merges... Hard to test otherwise.

msandstedt
msandstedt approved these changes Jul 8, 2021
@bzbarsky-apple
Copy link
Contributor Author

Doesn't this mean we can

Can which?

I'm still concerned that a newly scheduled bloat check might cancel a previously-pending one and hence lose its place in the queue... Not sure how that works, exactly.

@msandstedt
Copy link
Contributor

Doesn't this mean we can

Can which?

I'm still concerned that a newly scheduled bloat check might cancel a previously-pending one and hence lose its place in the queue... Not sure how that works, exactly.

Sorry, this was an inadvertent comment. I was typing while looking at the github docs.

But yes, by my reading new jobs will cancel previously-pending jobs. But these will no longer cancel the running job. This seems like it is what we want. We still have the maximum queue depth of 1, but ensure that the running job always completes.

@andy31415 andy31415 merged commit 2f6c61f into project-chip:master Jul 8, 2021
@bzbarsky-apple bzbarsky-apple deleted the fix-bloat-check-scheduling branch July 8, 2021 14:49
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants