Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowCovering: Add Target Positions support to scenes #8032

Merged

Conversation

jmeg-sfy
Copy link
Contributor

Problem

What is being fixed? Examples:

WindowCovering Cluster is outdated and date from ZCL
Define New Attributes and Commands required for Test Event
Rename Attributes and Commands accordingly with the Specs

Change overview

What's in this PR

This is the 3rd part of a multiple series of PRs to update the examples for Window Covering in order to simplify code reviews:

  • Update Scenes for Window Covering cluster with Target Positions

Testing

How was this tested? (at least one bullet point required)

  • Not tested: since SCENES features aren't completely supported yet and we need other dependencies in this cluster

@boring-cyborg boring-cyborg bot added the app label Jun 30, 2021
@jmeg-sfy jmeg-sfy changed the title WC: Add Target Positions support to scenes WindowCovering: Add Target Positions support to scenes Jun 30, 2021
@bzbarsky-apple bzbarsky-apple merged commit 81f0519 into project-chip:master Jul 9, 2021
@jmeg-sfy jmeg-sfy deleted the jmeg-sfy/window-covering-part-13 branch July 26, 2021 08:39
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…8032)

* WC: Add Target Positions support to scenes

* Restyle fixing

* Empty commit to kick restyled

Co-authored-by: Michael Spang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants