-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OnMessageReceived return error #7855
Merged
andy31415
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/error_message_received
Jun 23, 2021
Merged
Make OnMessageReceived return error #7855
andy31415
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/error_message_received
Jun 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
requested review from
bzbarsky-apple,
yufengwangca,
andy31415 and
msandstedt
June 23, 2021 19:09
Summary of Changes: OnMessageReceived in ExchangeDelegate don't return error so that we cannot test OnMessageReceived in Interaction Model protocol implementation.
yunhanw-google
force-pushed
the
feature/error_message_received
branch
from
June 23, 2021 19:21
be97a05
to
eba83db
Compare
msandstedt
approved these changes
Jun 23, 2021
Size increase report for "gn_qpg6100-example-build" from 039dfbd
Full report output
|
Size increase report for "esp32-example-build" from 039dfbd
Full report output
|
andy31415
approved these changes
Jun 23, 2021
Size increase report for "nrfconnect-example-build" from 039dfbd
Full report output
|
yufengwangca
approved these changes
Jun 23, 2021
jmartinez-silabs
approved these changes
Jun 23, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Summary of Changes: OnMessageReceived in ExchangeDelegate don't return error so that we cannot test OnMessageReceived in Interaction Model protocol implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
OnMessageReceived in ExchangeDelegate don't return error so that we
cannot test OnMessageReceived API in Interaction Model protocol
implementation.
It is not good to make friend class TestCommandInteraction, TestWriteInteraction,TestReadInteraction in Command, ReadClient/WriteClient, ReadHandler/WriteHandler. if we make OnMessageReceived with return error, it can decouple friend class.
In addition, in ExchangeContext, it is good to return error for mDelegate->OnMessageReceived(this, packetHeader, payloadHeader, std::move(msgBuf)) inside HandleMessage, currently we cannot return that error from OnMessageReceived
Change overview
Replace void with CHIP_ERROR for OnMessageReceived.
Testing
The existing tests cover this.