Use libshell under examples/platform/linux/AppMain.cpp only if chip_b… #7813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uild_libshell is true
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
Damian-Nordic
approved these changes
Jun 22, 2021
bzbarsky-apple
approved these changes
Jun 22, 2021
|
|
||
| declare_args() { | ||
| # Enable libshell support. | ||
| chip_build_libshell = false |
There was a problem hiding this comment.
This seems fine, but should this default to true on Linux to preserve current behavior?
There was a problem hiding this comment.
I'm fine to enable it back into examples/platform/linux/BUILD.gn for Linux platform if required. I have disabled it mostly because chip_build_libshell was false by default in src/lib/BUILD.gn and other platforms enable it conditionally.
Furthermore, I've tried to see what it does by typing commands in and there is not much commands at the moment, so I'm not sure how much it is used. Again if someone insist, I will add it back.
For references the commands are:
help
help
base64 Base64 encode / decode utilities
exit Exit the shell application
help List out all top level commands
version Output the software version
config Dump device configuration. Usage: config [param_name]
Done
andy31415
approved these changes
Jun 22, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…uild_libshell is true (project-chip#7813)
jamesharrow
added a commit
to jamesharrow/connectedhomeip
that referenced
this pull request
Nov 15, 2023
…7612e5cc3dd24e1bc6dd278462b9de8dcb9
jamesharrow
added a commit
to jamesharrow/connectedhomeip
that referenced
this pull request
Nov 19, 2023
jamesharrow
added a commit
that referenced
this pull request
Nov 19, 2023
… autogen code. Last commit before rebasing to upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uild_libshell is true
Problem
./scripts/tests/test_suites.shcan not be runned under darwin because of the usage of libshell.Change overview
examples/platform/linux/AppMain.cpponly ifchip_build_libshell=truetouch /tmp/all-clusters-logtoscripts/tests/test_suites.shto avoid an error messagegrep: /tmp/all-clusters-log: No such file or directoryTesting
This was tested running
scripts/tests/test_suites.shon the command line. It was not working previously.