-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate enumeration storage width #7746
Merged
mspang
merged 2 commits into
project-chip:master
from
vivien-apple:ZAP_EnumStorageWidth
Jun 18, 2021
Merged
Generate enumeration storage width #7746
mspang
merged 2 commits into
project-chip:master
from
vivien-apple:ZAP_EnumStorageWidth
Jun 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst,
selissia and
woody-apple
June 18, 2021 12:41
jmeg-sfy
approved these changes
Jun 18, 2021
…ce the storage of some enums has changed
Damian-Nordic
approved these changes
Jun 18, 2021
Size increase report for "nrfconnect-example-build" from 01ee80e
Full report output
|
Size increase report for "esp32-example-build" from 01ee80e
Full report output
|
andy31415
approved these changes
Jun 18, 2021
LuDuda
approved these changes
Jun 18, 2021
saurabhst
approved these changes
Jun 18, 2021
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jun 23, 2021
project-chip#7746 made the enums be sized correctly. Fixes project-chip#7622
woody-apple
pushed a commit
that referenced
this pull request
Jun 23, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Generate enumeration storage width * Update ChipLogDetail format of network-commissioning.cpp to PRIu8 since the storage of some enums has changed
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
project-chip#7746 made the enums be sized correctly. Fixes project-chip#7622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently enum are using
uint32_t
for their storage witdthChange overview
Testing
uint32_t
came from use the enumeration with an fixed underlying type #7266 because of some compilation issues) may want to double check it#Fixes #7394 ?