Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate enumeration storage width #7746

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

vivien-apple
Copy link
Contributor

@vivien-apple vivien-apple commented Jun 18, 2021

Problem

Currently enum are using uint32_t for their storage witdth

Change overview

  • Use the type specified in the enum definition

Testing

#Fixes #7394 ?

@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 01ee80e

File Section File VM
chip-lock.elf device_handles 12 12
chip-lock.elf rodata 0 4
chip-lock.elf text 4 4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
device_handles,12,12
.debug_line,0,8
.debug_frame,0,4
rodata,4,0
text,4,4
.debug_loc,0,-60

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build" from 01ee80e

File Section File VM
chip-all-clusters-app.elf .flash.text 80 80
chip-all-clusters-app.elf .dram0.bss 0 -304
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.text,80,80
.debug_info,0,42
.debug_line,0,40
.debug_loc,0,-2
.dram0.bss,-304,0


@mspang mspang merged commit 90637f2 into project-chip:master Jun 18, 2021
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Jun 23, 2021
woody-apple pushed a commit that referenced this pull request Jun 23, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* Generate enumeration storage width

* Update ChipLogDetail format of network-commissioning.cpp to PRIu8 since the storage of some enums has changed
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adaptive generated enumeration storage width
7 participants