-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ble connect error in Temperature Measurement app #7687
Conversation
@andy31415 @bzbarsky-apple Any idea why the ZAP templates generation has failed? |
/rebase |
4c8ba06
to
3cc4719
Compare
3cc4719
to
dba1c67
Compare
Done! |
Probably because it's catching that Probably what should happen here is changing |
dba1c67
to
5cb5206
Compare
Added this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions:
- Why is this adding Thread Network Diagnostics?
- This is putting Temperature Measurement on endpoint 0. What's the point of the (empty, no clusters enabled for it) endpoint 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes per @bzbarsky-apple
5cb5206
to
8aa6f6d
Compare
8aa6f6d
to
e6080cc
Compare
Added this change. cc: @bzbarsky-apple @woody-apple |
e6080cc
to
d0f2b1c
Compare
d0f2b1c
to
fd437ab
Compare
Approving for the 2nd commit you have added in this PR. |
* Fix ble connection in Temperature Measurement app * Fix resolve mdns in temperature measurement app
Problem
Change overview
Fix ble-connect error in temperature measurement app
Fix resolve mdns hang in temperature measurement app
Testing