Shut down InteractionModelEngine during DeviceController shutdown. #7629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise if we have an IM action in flight at shutdown time we will effectively leak the object managing it, and after a few shutdown/restart cycles for the stack not be able to send any more IM actions.
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
woody-apple
yunhanw-google
approved these changes
Jun 14, 2021
saurabhst
approved these changes
Jun 15, 2021
sagar-apple
approved these changes
Jun 15, 2021
msandstedt
approved these changes
Jun 15, 2021
woody-apple
approved these changes
Jun 15, 2021
jmartinez-silabs
approved these changes
Jun 15, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…roject-chip#7629) Otherwise if we have an IM action in flight at shutdown time we will effectively leak the object managing it, and after a few shutdown/restart cycles for the stack not be able to send any more IM actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise if we have an IM action in flight at shutdown time we will
effectively leak the object managing it, and after a few
shutdown/restart cycles for the stack not be able to send any more IM
actions.
Problem
If I shut down and restart DeviceController a few times, and the shutdowns happen to come while there is a CommandSender outstanding (in that we sent a command and a response has not come back), then eventually we run out of CommandSenders.
Change overview
Make sure to shut down CommandSenders when we shut down DeviceController.
Testing
Manual testing with a bug added to chip-all-clusters-app that causes it to shut down the DeviceController while CommandSenders are life. Will try to add some automated tests too.