-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve build coverage for Linux and Darwin #7625
Improve build coverage for Linux and Darwin #7625
Conversation
Log Upload #2227connectedhomeip/.github/workflows/build.yaml Lines 144 to 151 in 25fdda8
This comment was generated by todo based on a
|
#1512connectedhomeip/.github/workflows/build.yaml Lines 145 to 151 in 25fdda8
This comment was generated by todo based on a
|
This is going to build with clang in the "gcc" build and gcc in the "clang" build, etc. Currently CI is building the configs separately while the "unified" configuration tries to build them together. (Admittedly this does mean we get different coverage unless we work to keep them in sync) Should we perhaps instead augment examples-linux-standalone.yaml instead ? (and also run that on Mac) |
Excellent, this is just the sort of info I needed. ;) Let me look into that. I suspect on Mac I'll still want to do the thing I am doing now, because that matches what people run in practice to get an "up to date" Mac build, but I was hoping there was a less-expensive way to do the Linux bits. |
25fdda8
to
75be44c
Compare
@mspang please take a look? I went through the things the "default" build builds and looks like tv-app was the only one missing from examples-linux-standalone. |
Two changes here: 1) Build the tv-app example on Linux, in the examples-linux-standalone job. 2) Stand up build coverage equivalent to the "default" (i.e. including all the jobs that can be built on the OS) unified build on Darwin.
75be44c
to
286cd37
Compare
Two changes here: 1) Build the tv-app example on Linux, in the examples-linux-standalone job. 2) Stand up build coverage equivalent to the "default" (i.e. including all the jobs that can be built on the OS) unified build on Darwin.
Two changes here:
Pass target_os="all" to the existing Linux builds, so it will build
the various "linux" versions of things like tv-app.
Stand up build coverage of the same sort on Darwin.
Problem
It turned out we had no CI building the "linux" versions of things like tv-app on Darwin, and possibly not on Linux either.
Change overview
Run the "build" task on Darwin as well, and change the "build" task to do
target_is="all"
.The latter required bumping up the build and test timeouts on the Linux tests. Basically, the opt gcc builds now take 20-25 mins and the debug gcc tests take 7-10 minutes. The sum of the build and test times for both seems to be in the ~23 minute range.
Testing