Controller error no device layer inet system shutdown #7605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
|
Added "Tested manually" label with the assumption of 'compilation test only'. "No tests at all but hoping we will have tests later" statement is a bit scary though |
andy31415
approved these changes
Jun 14, 2021
jelderton
approved these changes
Jun 14, 2021
saurabhst
approved these changes
Jun 14, 2021
Agreed. So far the controllers that have tests calling |
…ed and something unexpected happens during inet/system shutdown
vivien-apple
force-pushed
the
Controller_ErrorNoDeviceLayerInetSystemShutdown
branch
from
53b874a to
02c1d6b
Compare
msandstedt
approved these changes
Jun 15, 2021
woody-apple
approved these changes
Jun 15, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…ed and something unexpected happens during inet/system shutdown (project-chip#7605)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Errors into inet/system does not propagate into
CHIPDeviceController::Shutdownif no device layer is used.Change overview
Testing
src/app/tests/suites/to generate some tests for it at some point.