Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "OTAServerDelegate class for vendor logic" #7534

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

woody-apple
Copy link
Contributor

Reverts #6476

@woody-apple woody-apple added the hotfix urgent fix needed, can bypass review label Jun 10, 2021
@pullapprove pullapprove bot added review - pending and removed hotfix urgent fix needed, can bypass review labels Jun 10, 2021
@woody-apple
Copy link
Contributor Author

@holbrookt as an FYI

@woody-apple woody-apple merged commit d29749b into master Jun 10, 2021
@woody-apple woody-apple deleted the revert-6476-ota-server-cluster-common branch June 10, 2021 21:34
@bzbarsky-apple
Copy link
Contributor

fix-logging.txt should fix the build problem....

@github-actions
Copy link

ESP32 Symbols Diff from 23f37bf

Full output
change a-size b-size symbol
624    132    756   CSWTCH$1
384    256    640   K
96     16    112   CSWTCH$1
44      4     48   __compound_literal$2
20    941    961   emberAfClusterInitCallback(unsigned char, unsigned short)
20   1000   1020   generatedClusters
19     11     30   __func__$7439
16      4     20   stateTable
15     21     36   semphr_take_wrapper
14     21     35   queue_send_wrapper
13      4     17   CSWTCH$22
12     11     23   __func__$7339
12   3768   3780   generatedAttributes
11      6     17   CSWTCH$28
10      6     16   CSWTCH$30
 9     46     55   emberAfPluginReportingInitCallback()
 7     11     18   __func__$7379
 6      6     12   CSWTCH$29
 6      4     10   TAG
 6     30     36   task_create_wrapper
 5      0      5   emberAfOtaSoftwareUpdateClientClusterInitCallback(unsigned char)
 4     17     21   mutex_lock_wrapper
 3     10     13   TAG
 3      5      8   chip_name
 2     11     13   __func__$7515
 2   8915   8917   attributeData
-1     17     16   CSWTCH$28
-2     13     11   __func__$7515
-3     13     10   TAG
-3      8      5   chip_name
-4      4      0   (anonymous namespace)::gDelegateTable
-4     21     17   mutex_lock_wrapper
-6     12      6   CSWTCH$29
-6     10      4   TAG
-6     36     30   task_create_wrapper
-7     18     11   __func__$7379
-10     16      6   CSWTCH$28
-10     16      6   CSWTCH$30
-12     23     11   __func__$7339
-13     17      4   CSWTCH$22
-14     35     21   queue_send_wrapper
-15     36     21   semphr_take_wrapper
-16     20      4   stateTable
-19     30     11   __func__$7439
-24    456    432   emAfPluginReportVolatileData
-30     30      0   (anonymous namespace)::GetDelegate(unsigned char)
-32    608    576   generatedReportingConfigDefaults
-40     40      0   (anonymous namespace)::SendStatusIfDelegateNull(unsigned char)
-44     48      4   __compound_literal$2
-64   1216   1152   table
-83     90      7   emberAfOtaSoftwareUpdateServerClusterApplyUpdateRequestCallback(chip::app::Command*, chip::Span<unsigned char>, unsigned int)
-83     90      7   emberAfOtaSoftwareUpdateServerClusterNotifyUpdateAppliedCallback(chip::app::Command*, chip::Span<unsigned char>, unsigned int)
-96    112     16   CSWTCH$1
-166    173      7   emberAfOtaSoftwareUpdateServerClusterQueryImageCallback(chip::app::Command*, unsigned short, unsigned short, unsigned short, unsigned short, unsigned int, unsigned char*, unsigned char*, unsigned char, chip::Span<unsigned char>)
-384    640    256   K
-624    756    132   CSWTCH$1

@github-actions
Copy link

Size increase report for "esp32-example-build" from 23f37bf

File Section File VM
chip-all-clusters-app.elf .dram0.bss 0 -96
chip-all-clusters-app.elf .flash.rodata -256 -256
chip-all-clusters-app.elf .flash.text -396 -396
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,256
.shstrtab,0,3
.debug_aranges,0,-32
.symtab,0,-32
.debug_frame,0,-48
.debug_ranges,0,-56
.strtab,0,-59
.dram0.bss,-96,0
.debug_str,0,-147
.flash.rodata,-256,-256
.debug_abbrev,0,-286
.flash.text,-396,-396
.debug_loc,0,-661
.debug_line,0,-1217
.debug_info,0,-2321


@holbrookt
Copy link
Contributor

filed a new PR at #7537

nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants