Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort includes setup_payload #714

Merged
merged 2 commits into from
May 15, 2020
Merged

sort includes setup_payload #714

merged 2 commits into from
May 15, 2020

Conversation

rwalker-apple
Copy link
Contributor

Problem

includes aren't sorted

Summary of Changes

  • sort includes
  • make blocks
  • other small grooming, e.g. module header files

working on #116, part of #683

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #714 into master will decrease coverage by 1.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
- Coverage   60.18%   58.36%   -1.82%     
==========================================
  Files         130      130              
  Lines       12670    12659      -11     
==========================================
- Hits         7626     7389     -237     
- Misses       5044     5270     +226
Impacted Files Coverage Δ
src/setup_payload/ManualSetupPayloadGenerator.h 100.00% <ø> (ø)
src/setup_payload/ManualSetupPayloadParser.cpp 95.12% <ø> (ø)
src/setup_payload/tests/TestManualCode.cpp 95.16% <ø> (ø)
src/setup_payload/tests/TestManualCodeDriver.cpp 100.00% <ø> (ø)
src/setup_payload/tests/TestQRCode.cpp 99.48% <ø> (ø)
src/setup_payload/tests/TestQRCodeDriver.cpp 100.00% <ø> (ø)
src/lib/core/CHIPEncoding.h 47.05% <0.00%> (-45.54%) ⬇️
src/inet/InetLayer.cpp 0.00% <0.00%> (-36.65%) ⬇️
src/inet/IPEndPointBasis.cpp 0.00% <0.00%> (-36.46%) ⬇️
src/lib/core/CHIPTLVTags.h 66.66% <0.00%> (-33.34%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4babc...6519e61. Read the comment docs.

@rwalker-apple
Copy link
Contributor Author

@saurabhst @hawk248 @jelderton ?

@woody-apple woody-apple merged commit 65233e8 into project-chip:master May 15, 2020
@rwalker-apple rwalker-apple deleted the sort-includes-setup_payload branch May 15, 2020 01:40
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request May 2, 2023
@CuRahman @jmartinez-silabs
Pull request project-chip#714: Added back only code size analysis on …
9eab862 
…main dev branches

Merge in WMN_TOOLS/matter from feature/revert_code_size_analysis to silabs

Squashed commit of the following:

commit 1b4f79e369f9d38a49410bb4541d7ce9d6cbc4ad
Author: Curtis Rahman <[email protected]>
Date:   Tue Apr 25 14:25:25 2023 -0400

    Added back only code size analysis on main dev branches
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@CuRahman @jmartinez-silabs
Pull request project-chip#714: Added back only code size analysis on …
f0ea46b 
…main dev branches

Merge in WMN_TOOLS/matter from feature/revert_code_size_analysis to silabs

Squashed commit of the following:

commit 1b4f79e369f9d38a49410bb4541d7ce9d6cbc4ad
Author: Curtis Rahman <[email protected]>
Date:   Tue Apr 25 14:25:25 2023 -0400

    Added back only code size analysis on main dev branches
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@CuRahman @jmartinez-silabs
Pull request project-chip#714: Added back only code size analysis on …
ba8e560 
…main dev branches

Merge in WMN_TOOLS/matter from feature/revert_code_size_analysis to silabs

Squashed commit of the following:

commit 1b4f79e369f9d38a49410bb4541d7ce9d6cbc4ad
Author: Curtis Rahman <[email protected]>
Date:   Tue Apr 25 14:25:25 2023 -0400

    Added back only code size analysis on main dev branches
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@CuRahman @jmartinez-silabs
Pull request project-chip#714: Added back only code size analysis on …
3ba262d 
…main dev branches

Merge in WMN_TOOLS/matter from feature/revert_code_size_analysis to silabs

Squashed commit of the following:

commit 1b4f79e369f9d38a49410bb4541d7ce9d6cbc4ad
Author: Curtis Rahman <[email protected]>
Date:   Tue Apr 25 14:25:25 2023 -0400

    Added back only code size analysis on main dev branches
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@CuRahman @jmartinez-silabs
Pull request project-chip#714: Added back only code size analysis on …
7687e3b 
…main dev branches

Merge in WMN_TOOLS/matter from feature/revert_code_size_analysis to silabs

Squashed commit of the following:

commit 1b4f79e369f9d38a49410bb4541d7ce9d6cbc4ad
Author: Curtis Rahman <[email protected]>
Date:   Tue Apr 25 14:25:25 2023 -0400

    Added back only code size analysis on main dev branches
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@CuRahman @jmartinez-silabs
Pull request project-chip#714: Added back only code size analysis on …
ad71711 
…main dev branches

Merge in WMN_TOOLS/matter from feature/revert_code_size_analysis to silabs

Squashed commit of the following:

commit 1b4f79e369f9d38a49410bb4541d7ce9d6cbc4ad
Author: Curtis Rahman <[email protected]>
Date:   Tue Apr 25 14:25:25 2023 -0400

    Added back only code size analysis on main dev branches
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@CuRahman @jmartinez-silabs
Pull request project-chip#714: Added back only code size analysis on …
a9114c3 
…main dev branches

Merge in WMN_TOOLS/matter from feature/revert_code_size_analysis to silabs

Squashed commit of the following:

commit 1b4f79e369f9d38a49410bb4541d7ce9d6cbc4ad
Author: Curtis Rahman <[email protected]>
Date:   Tue Apr 25 14:25:25 2023 -0400

    Added back only code size analysis on main dev branches
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
@CuRahman @jmartinez-silabs
Pull request project-chip#714: Added back only code size analysis on …
22f8b96 
…main dev branches

Merge in WMN_TOOLS/matter from feature/revert_code_size_analysis to silabs

Squashed commit of the following:

commit 1b4f79e369f9d38a49410bb4541d7ce9d6cbc4ad
Author: Curtis Rahman <[email protected]>
Date:   Tue Apr 25 14:25:25 2023 -0400

    Added back only code size analysis on main dev branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@gerickson gerickson gerickson approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwalker-apple @gerickson @saurabhst @woody-apple