Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort includes platform #713

Merged
merged 1 commit into from
May 15, 2020
Merged

sort includes platform #713

merged 1 commit into from
May 15, 2020

Conversation

rwalker-apple
Copy link
Contributor

Problem

includes aren't sorted

Summary of Changes

  • make blocks

working on #116, part of #683

@codecov
Copy link

codecov bot commented May 14, 2020 •
edited
Loading

Codecov Report

Merging #713 into master will decrease coverage by 1.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
- Coverage   60.18%   58.49%   -1.70%     
==========================================
  Files         130      130              
  Lines       12670    12656      -14     
==========================================
- Hits         7626     7403     -223     
- Misses       5044     5253     +209
Impacted Files Coverage Δ
src/inet/EndPointBasis.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/inet/InetLayerBasis.cpp 0.00% <0.00%> (-80.00%) ⬇️
src/setup_payload/SetupPayload.cpp 29.16% <0.00%> (-66.67%) ⬇️
src/system/SystemError.cpp 8.16% <0.00%> (-61.23%) ⬇️
src/inet/IPAddress-StringFuncts.cpp 0.00% <0.00%> (-42.86%) ⬇️
src/inet/InetLayer.cpp 0.00% <0.00%> (-36.65%) ⬇️
src/inet/IPEndPointBasis.cpp 0.00% <0.00%> (-36.46%) ⬇️
src/lib/core/CHIPEncoding.h 73.91% <0.00%> (-18.68%) ⬇️
src/system/SystemFaultInjection.cpp 31.81% <0.00%> (-18.19%) ⬇️
src/system/SystemObject.cpp 87.50% <0.00%> (-6.25%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4babc...21bab74. Read the comment docs.

@rwalker-apple
Copy link
Contributor Author

@jelderton @hawk248 @saurabhst ?

@woody-apple woody-apple merged commit 20a13ca into project-chip:master May 15, 2020
@rwalker-apple rwalker-apple deleted the sort-includes-platform branch May 15, 2020 01:40
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request May 2, 2023
@jmartinez-silabs
Pull request project-chip#713: Use --use_ot_lib for the release build…
93a1c4f 
… use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define

Merge in WMN_TOOLS/matter from fix/NDEBUG_release to silabs

Squashed commit of the following:

commit 682967c9a8353384d871aa99a4269ae427b89dd8
Author: Junior Martinez <[email protected]>
Date:   Tue Apr 25 10:31:36 2023 -0400

    Use --use_ot_lib for the release build use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@jmartinez-silabs
Pull request project-chip#713: Use --use_ot_lib for the release build…
0ea7c39 
… use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define

Merge in WMN_TOOLS/matter from fix/NDEBUG_release to silabs

Squashed commit of the following:

commit 682967c9a8353384d871aa99a4269ae427b89dd8
Author: Junior Martinez <[email protected]>
Date:   Tue Apr 25 10:31:36 2023 -0400

    Use --use_ot_lib for the release build use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@jmartinez-silabs
Pull request project-chip#713: Use --use_ot_lib for the release build…
bd40d38 
… use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define

Merge in WMN_TOOLS/matter from fix/NDEBUG_release to silabs

Squashed commit of the following:

commit 682967c9a8353384d871aa99a4269ae427b89dd8
Author: Junior Martinez <[email protected]>
Date:   Tue Apr 25 10:31:36 2023 -0400

    Use --use_ot_lib for the release build use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@jmartinez-silabs
Pull request project-chip#713: Use --use_ot_lib for the release build…
799b890 
… use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define

Merge in WMN_TOOLS/matter from fix/NDEBUG_release to silabs

Squashed commit of the following:

commit 682967c9a8353384d871aa99a4269ae427b89dd8
Author: Junior Martinez <[email protected]>
Date:   Tue Apr 25 10:31:36 2023 -0400

    Use --use_ot_lib for the release build use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@jmartinez-silabs
Pull request project-chip#713: Use --use_ot_lib for the release build…
2c4a052 
… use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define

Merge in WMN_TOOLS/matter from fix/NDEBUG_release to silabs

Squashed commit of the following:

commit 682967c9a8353384d871aa99a4269ae427b89dd8
Author: Junior Martinez <[email protected]>
Date:   Tue Apr 25 10:31:36 2023 -0400

    Use --use_ot_lib for the release build use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@jmartinez-silabs
Pull request project-chip#713: Use --use_ot_lib for the release build…
964ec9c 
… use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define

Merge in WMN_TOOLS/matter from fix/NDEBUG_release to silabs

Squashed commit of the following:

commit 682967c9a8353384d871aa99a4269ae427b89dd8
Author: Junior Martinez <[email protected]>
Date:   Tue Apr 25 10:31:36 2023 -0400

    Use --use_ot_lib for the release build use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@jmartinez-silabs
Pull request project-chip#713: Use --use_ot_lib for the release build…
2167ac7 
… use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define

Merge in WMN_TOOLS/matter from fix/NDEBUG_release to silabs

Squashed commit of the following:

commit 682967c9a8353384d871aa99a4269ae427b89dd8
Author: Junior Martinez <[email protected]>
Date:   Tue Apr 25 10:31:36 2023 -0400

    Use --use_ot_lib for the release build use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
@jmartinez-silabs
Pull request project-chip#713: Use --use_ot_lib for the release build…
b0d9b32 
… use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define

Merge in WMN_TOOLS/matter from fix/NDEBUG_release to silabs

Squashed commit of the following:

commit 682967c9a8353384d871aa99a4269ae427b89dd8
Author: Junior Martinez <[email protected]>
Date:   Tue Apr 25 10:31:36 2023 -0400

    Use --use_ot_lib for the release build use until we find a fix in the thread stack causing the SRP service to fail with NDEBUG define
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@gerickson gerickson gerickson approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwalker-apple @gerickson @saurabhst @woody-apple