Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort includes src/plaform/FreeRTOS #712

Conversation

rwalker-apple
Copy link
Contributor

@rwalker-apple rwalker-apple commented May 14, 2020

Problem

includes aren't sorted

Summary of Changes

  • sort includes
    *make blocks

working on #116, part of #683

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #712 into master will decrease coverage by 2.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   60.18%   57.78%   -2.41%     
==========================================
  Files         130      130              
  Lines       12670    12648      -22     
==========================================
- Hits         7626     7309     -317     
- Misses       5044     5339     +295     
Impacted Files Coverage Δ
src/inet/InetFaultInjection.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/ble/BleError.cpp 0.00% <0.00%> (-99.05%) ⬇️
src/inet/InetLayerBasis.cpp 0.00% <0.00%> (-80.00%) ⬇️
src/inet/UDPEndPoint.cpp 0.00% <0.00%> (-63.81%) ⬇️
src/system/SystemError.cpp 8.16% <0.00%> (-61.23%) ⬇️
src/system/SystemPacketBuffer.cpp 49.71% <0.00%> (-47.46%) ⬇️
src/lib/core/CHIPEncoding.h 47.05% <0.00%> (-45.54%) ⬇️
src/lib/core/CHIPTLVTags.h 66.66% <0.00%> (-33.34%) ⬇️
src/setup_payload/SetupPayload.cpp 66.66% <0.00%> (-29.17%) ⬇️
src/inet/IPAddress.cpp 0.00% <0.00%> (-18.25%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4babc...b650652. Read the comment docs.

@rwalker-apple
Copy link
Contributor Author

@hawk248 @jelderton @saurabhst ?

@woody-apple woody-apple merged commit acc4ca7 into project-chip:master May 15, 2020
@rwalker-apple rwalker-apple deleted the sort-includes-src-plaform-FreeRTOS branch May 15, 2020 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants