Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate QEMU testing to CI #708

Closed
wants to merge 5 commits into from
Closed

Integrate QEMU testing to CI #708

wants to merge 5 commits into from

Conversation

pan-apple
Copy link
Contributor

Problem

The CHIP test for ESP32 QEMU are available. But, the CI is not running these tests.

Summary of Changes

Integrate tests to Circle CI

fixes #707

@restyled-io restyled-io bot mentioned this pull request May 14, 2020
Closed
@codecov
Copy link

codecov bot commented May 14, 2020 •
edited
Loading

Codecov Report

Merging #708 into master will decrease coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
- Coverage   58.24%   57.68%   -0.57%     
==========================================
  Files         130      130              
  Lines       12652    12652              
==========================================
- Hits         7369     7298      -71     
- Misses       5283     5354      +71
Impacted Files Coverage Δ
src/inet/InetFaultInjection.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/ble/BleError.cpp 0.00% <0.00%> (-99.05%) ⬇️
src/inet/UDPEndPoint.cpp 0.00% <0.00%> (-63.81%) ⬇️
src/system/SystemError.cpp 8.16% <0.00%> (-61.23%) ⬇️
src/system/SystemPacketBuffer.cpp 49.71% <0.00%> (-46.33%) ⬇️
src/inet/IPAddress-StringFuncts.cpp 0.00% <0.00%> (-42.86%) ⬇️
src/setup_payload/SetupPayload.cpp 29.16% <0.00%> (-37.50%) ⬇️
src/inet/IPAddress.cpp 0.00% <0.00%> (-18.25%) ⬇️
src/inet/TCPEndPoint.h 0.00% <0.00%> (ø)
src/inet/InetInterface.h 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4babc...5a7c576. Read the comment docs.

rwalker-apple
rwalker-apple suggested changes May 14, 2020
View reviewed changes
Copy link
Contributor

@rwalker-apple rwalker-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would venture that running our tests on one of our supported platforms probably shouldn't live in examples/...

@pan-apple
Copy link
Contributor Author

I would venture that running our tests on one of our supported platforms probably shouldn't live in examples/...

@rwalker-apple any suggestions on a better location?

@restyled-io restyled-io bot mentioned this pull request May 14, 2020
Closed
@rwalker-apple
Copy link
Contributor

I would venture that running our tests on one of our supported platforms probably shouldn't live in examples/...

@rwalker-apple any suggestions on a better location?

What if we put something in tools that represented minimal builds for each of our environments? Into those builds we could insert a test main function (or a test task, or something).

tools/check/ESP32-qemu/...

Then we could point our make system at those images for running check-TESTS targets.

Just brainstorming.

Goals:

  • device simulator unit test environment that mimics as closely as possible the standalone environment
  • unit-test isolation and modularity no assumption about test order, no facility for unit tests to interfere with each other
  • quick iteration, i.e. configure for esp32-qemu + make -C src/<module>/tests check-TESTS is the dev model

Semi-goals:

  • collection of coverage, implies a simulated FS ;)

@pan-apple
Copy link
Contributor Author

I would venture that running our tests on one of our supported platforms probably shouldn't live in examples/...

@rwalker-apple any suggestions on a better location?

What if we put something in tools that represented minimal builds for each of our environments? Into those builds we could insert a test main function (or a test task, or something).

tools/check/ESP32-qemu/...

Then we could point our make system at those images for running check-TESTS targets.

Just brainstorming.

Goals:

  • device simulator unit test environment that mimics as closely as possible the standalone environment
  • unit-test isolation and modularity no assumption about test order, no facility for unit tests to interfere with each other
  • quick iteration, i.e. configure for esp32-qemu + make -C src/<module>/tests check-TESTS is the dev model

Semi-goals:

  • collection of coverage, implies a simulated FS ;)

@rwalker-apple maybe we can use the term test_driver, as all unit tests are now split into a test lib, and a driver that calls the entry point of the test lib. The code that drives the standalone unit tests is already called <test>Driver.cpp.

The src/test_driver/ folder can contain driver for each type of platform, and can be built along with rest of the source tree. Rest, it can follow the model you mentioned above.

@pan-apple pan-apple mentioned this pull request May 14, 2020
Closed
@pan-apple
Copy link
Contributor Author

Closing the PR until we have a consensus on issue #721

@pan-apple pan-apple closed this May 14, 2020
@pan-apple pan-apple deleted the qemu-ci branch May 21, 2020 15:17
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request May 2, 2023
@chirag-silabs @jmartinez-silabs
Pull request project-chip#708: Adding the RPS file for the 917 SoC
7614836 
Merge in WMN_TOOLS/matter from feature/rps_addition to silabs

Squashed commit of the following:

commit 4dd69cd1149253ee8cb60e46cf08219f78dc48ed
Author: Chirag Bansal <[email protected]>
Date:   Thu Apr 27 00:06:51 2023 +0530

    adding the / to save the path

commit e3b8817254a2c06b2af8faa92b9ac39706a514ee
Author: Chirag Bansal <[email protected]>
Date:   Wed Apr 26 22:59:25 2023 +0530

    updated the path of rps file due to change in the path

commit e195ffc754f79d8f4e41254d31ae8eff5c90d793
Author: Chirag Bansal <[email protected]>
Date:   Sat Apr 22 16:33:17 2023 +0530

    saving the file name with the example

... and 9 more commits
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Oct 5, 2023
@chirag-silabs @jmartinez-silabs
Pull request project-chip#708: Adding the RPS file for the 917 SoC
8df13ff 
Merge in WMN_TOOLS/matter from feature/rps_addition to silabs

Squashed commit of the following:

commit 4dd69cd1149253ee8cb60e46cf08219f78dc48ed
Author: Chirag Bansal <[email protected]>
Date:   Thu Apr 27 00:06:51 2023 +0530

    adding the / to save the path

commit e3b8817254a2c06b2af8faa92b9ac39706a514ee
Author: Chirag Bansal <[email protected]>
Date:   Wed Apr 26 22:59:25 2023 +0530

    updated the path of rps file due to change in the path

commit e195ffc754f79d8f4e41254d31ae8eff5c90d793
Author: Chirag Bansal <[email protected]>
Date:   Sat Apr 22 16:33:17 2023 +0530

    saving the file name with the example

... and 9 more commits
shgutte pushed a commit to shgutte/connectedhomeip that referenced this pull request Jan 11, 2024
@chirag-silabs @jmartinez-silabs
Pull request project-chip#708: Adding the RPS file for the 917 SoC
ea2ab75 
Merge in WMN_TOOLS/matter from feature/rps_addition to silabs

Squashed commit of the following:

commit 4dd69cd1149253ee8cb60e46cf08219f78dc48ed
Author: Chirag Bansal <[email protected]>
Date:   Thu Apr 27 00:06:51 2023 +0530

    adding the / to save the path

commit e3b8817254a2c06b2af8faa92b9ac39706a514ee
Author: Chirag Bansal <[email protected]>
Date:   Wed Apr 26 22:59:25 2023 +0530

    updated the path of rps file due to change in the path

commit e195ffc754f79d8f4e41254d31ae8eff5c90d793
Author: Chirag Bansal <[email protected]>
Date:   Sat Apr 22 16:33:17 2023 +0530

    saving the file name with the example

... and 9 more commits
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@chirag-silabs @jmartinez-silabs
Pull request project-chip#708: Adding the RPS file for the 917 SoC
d641ae1 
Merge in WMN_TOOLS/matter from feature/rps_addition to silabs

Squashed commit of the following:

commit 4dd69cd1149253ee8cb60e46cf08219f78dc48ed
Author: Chirag Bansal <[email protected]>
Date:   Thu Apr 27 00:06:51 2023 +0530

    adding the / to save the path

commit e3b8817254a2c06b2af8faa92b9ac39706a514ee
Author: Chirag Bansal <[email protected]>
Date:   Wed Apr 26 22:59:25 2023 +0530

    updated the path of rps file due to change in the path

commit e195ffc754f79d8f4e41254d31ae8eff5c90d793
Author: Chirag Bansal <[email protected]>
Date:   Sat Apr 22 16:33:17 2023 +0530

    saving the file name with the example

... and 9 more commits
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Jan 29, 2024
@chirag-silabs @jmartinez-silabs
Pull request project-chip#708: Adding the RPS file for the 917 SoC
5e6874c 
Merge in WMN_TOOLS/matter from feature/rps_addition to silabs

Squashed commit of the following:

commit 4dd69cd1149253ee8cb60e46cf08219f78dc48ed
Author: Chirag Bansal <[email protected]>
Date:   Thu Apr 27 00:06:51 2023 +0530

    adding the / to save the path

commit e3b8817254a2c06b2af8faa92b9ac39706a514ee
Author: Chirag Bansal <[email protected]>
Date:   Wed Apr 26 22:59:25 2023 +0530

    updated the path of rps file due to change in the path

commit e195ffc754f79d8f4e41254d31ae8eff5c90d793
Author: Chirag Bansal <[email protected]>
Date:   Sat Apr 22 16:33:17 2023 +0530

    saving the file name with the example

... and 9 more commits
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@chirag-silabs @jmartinez-silabs
Pull request project-chip#708: Adding the RPS file for the 917 SoC
ed17f8c 
Merge in WMN_TOOLS/matter from feature/rps_addition to silabs

Squashed commit of the following:

commit 4dd69cd1149253ee8cb60e46cf08219f78dc48ed
Author: Chirag Bansal <[email protected]>
Date:   Thu Apr 27 00:06:51 2023 +0530

    adding the / to save the path

commit e3b8817254a2c06b2af8faa92b9ac39706a514ee
Author: Chirag Bansal <[email protected]>
Date:   Wed Apr 26 22:59:25 2023 +0530

    updated the path of rps file due to change in the path

commit e195ffc754f79d8f4e41254d31ae8eff5c90d793
Author: Chirag Bansal <[email protected]>
Date:   Sat Apr 22 16:33:17 2023 +0530

    saving the file name with the example

... and 9 more commits
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Jun 20, 2024
@chirag-silabs @jmartinez-silabs
Pull request project-chip#708: Adding the RPS file for the 917 SoC
d062e25 
Merge in WMN_TOOLS/matter from feature/rps_addition to silabs

Squashed commit of the following:

commit 4dd69cd1149253ee8cb60e46cf08219f78dc48ed
Author: Chirag Bansal <[email protected]>
Date:   Thu Apr 27 00:06:51 2023 +0530

    adding the / to save the path

commit e3b8817254a2c06b2af8faa92b9ac39706a514ee
Author: Chirag Bansal <[email protected]>
Date:   Wed Apr 26 22:59:25 2023 +0530

    updated the path of rps file due to change in the path

commit e195ffc754f79d8f4e41254d31ae8eff5c90d793
Author: Chirag Bansal <[email protected]>
Date:   Sat Apr 22 16:33:17 2023 +0530

    saving the file name with the example

... and 9 more commits
chirag-silabs added a commit to rosahay-silabs/connectedhomeip that referenced this pull request Jul 15, 2024
@chirag-silabs @jmartinez-silabs
Pull request project-chip#708: Adding the RPS file for the 917 SoC
858a8b6 
Merge in WMN_TOOLS/matter from feature/rps_addition to silabs

Squashed commit of the following:

commit 4dd69cd1149253ee8cb60e46cf08219f78dc48ed
Author: Chirag Bansal <[email protected]>
Date:   Thu Apr 27 00:06:51 2023 +0530

    adding the / to save the path

commit e3b8817254a2c06b2af8faa92b9ac39706a514ee
Author: Chirag Bansal <[email protected]>
Date:   Wed Apr 26 22:59:25 2023 +0530

    updated the path of rps file due to change in the path

commit e195ffc754f79d8f4e41254d31ae8eff5c90d793
Author: Chirag Bansal <[email protected]>
Date:   Sat Apr 22 16:33:17 2023 +0530

    saving the file name with the example

... and 9 more commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwalker-apple rwalker-apple rwalker-apple requested changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@BroderickCarlin BroderickCarlin Awaiting requested review from BroderickCarlin

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@gerickson gerickson Awaiting requested review from gerickson

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI does not run QEMU ESP32 tests
3 participants
@pan-apple @rwalker-apple @restyled-commits