-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[controller] Move callbacks to CommandResponseStatus since timing related issue is resolved. #7060
Merged
andy31415
merged 1 commit into
project-chip:master
from
erjiaqing:im-delegate-controller-fix
May 31, 2021
Merged
[controller] Move callbacks to CommandResponseStatus since timing related issue is resolved. #7060
andy31415
merged 1 commit into
project-chip:master
from
erjiaqing:im-delegate-controller-fix
May 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated issue is resolved.
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
May 24, 2021 11:47
msandstedt
approved these changes
May 26, 2021
andy31415
approved these changes
May 27, 2021
tcarmelveilleux
approved these changes
May 27, 2021
jelderton
approved these changes
May 28, 2021
andy31415
approved these changes
May 31, 2021
Can confirm this regressed the tests in Darwin here: Looks like a real failure |
Confirmed this PR had a failed build due a regression here: |
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Jun 1, 2021
…ming related issue is resolved. (project-chip#7060)" This reverts commit 46599f3.
This was referenced Jun 1, 2021
erjiaqing
added a commit
to erjiaqing/connectedhomeip
that referenced
this pull request
Jun 11, 2021
…since timing related issue is resolved. (project-chip#7060)" (project-chip#7276)" This reverts commit 872051e.
andy31415
pushed a commit
that referenced
this pull request
Jun 11, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…ated issue is resolved. (project-chip#7060)
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…ming related issue is resolved. (project-chip#7060)" (project-chip#7276) This reverts commit 46599f3.
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…since timing related issue is resolved. (project-chip#7060)" (project-chip#7276)" (project-chip#7542) This reverts commit 872051e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DeviceControllerInteractionModelDelegate
is introduced with some workaround to fix timing issues for callback manager.Change overview
Testing
The test is covered by Darwin tests that the callbacks can be called correctly.
This PR requires #7041 and #7114