Update CRMP test to wait for ack and check retransmit table #7008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woody-apple
approved these changes
May 20, 2021
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
andy31415
approved these changes
May 20, 2021
|
Size increase report for "esp32-example-build" from 3eec7c3
Full report output |
andy31415
approved these changes
May 21, 2021
bzbarsky-apple
approved these changes
May 22, 2021
| @@ -155,8 +156,7 @@ void ReliableMessageMgr::ExecuteActions() | |||
| // If the retransmission was successful, update the passive timer | |||
| entry.nextRetransTimeTick = static_cast<uint16_t>(rc->GetActiveRetransmitTimeoutTick()); | |||
| #if !defined(NDEBUG) | |||
| ChipLogDetail(ExchangeManager, "Retransmit MsgId:%08" PRIX32 " Send Cnt %d", entry.retainedBuf.GetMsgId(), | |||
| entry.sendCount); | |||
| ChipLogDetail(ExchangeManager, "Retransmit MsgId:%08" PRIX32 " Send Cnt %d", msgId, entry.sendCount); | |||
msandstedt
approved these changes
May 22, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…chip#7008) * Update CRMP test to wait for ack and check retransmit table * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TestReliableMessageProtocol::CheckResendMessageunit test could be updated to wait for the ack from peer, and make sure it gets processed correctly.Change overview
Updated the unit test. The test can now selectively drop message (and retries). It also processes the ack response from the peer, and confirms that the retransmit table is in the correct state.
Testing
The unit test
TestReliableMessageProtocol::CheckResendMessageis itself the test that verifies it.