Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[esp32] increase default stack size #6869

Merged
merged 1 commit into from
May 17, 2021

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented May 17, 2021

Problem

The stack overflows when running PASE pairing after the operational credentials change.

Summary of Changes

Increase the default stack size to 8192.

The added operational credentials feature requires more stack size
because of the mbedtls api calls.
@github-actions
Copy link

Size increase report for "esp32-example-build" from 8a51de2

File Section File VM
chip-all-clusters-app.elf .flash.text -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_loc,0,4
.flash.text,-4,-4


@dhrishi
Copy link
Contributor

dhrishi commented May 17, 2021

@gjc13 Is crypto (mbedTLS) used with the recent changes related to operational credentials? If yes, we prefer/suggest keeping the stack size as minimum 8KB. LGTM

@woody-apple woody-apple merged commit 5780db7 into project-chip:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants