Remove peerNodeId in MCSP receive table (Fix: #6340)

[kghost]

Fixes: #6340

[kghost]

This PR is trying to reduce memory usage of MCSP retrans table in bss section. But ends up using more memory.

.text increased by function MessageCounterManager::ProcessPendingMessages, which is decoding the packet header.

  78    106    184   chip::secure_channel::MessageCounterManager::ProcessPendingMessages(unsigned long long)

.rodata is probably increased by the error log string (length 77 bytes):

MessageCounterManager::ProcessPendingMessages: Failed to decode PacketHeader

[woody-apple]

/rebase

[kghost]

qpg is encountering memory problem again. I'll rebase this PR over #6874 once it is merge, #6874 will free up around 1K mem.

[github-actions]

Size increase report for "esp32-example-build" from a95b622

File	Section	File	VM
chip-all-clusters-app.elf	.flash.rodata	80	80
chip-all-clusters-app.elf	.flash.text	28	28
chip-all-clusters-app.elf	.dram0.bss	0	-72

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,819
.debug_loc,0,400
.debug_line,0,392
.debug_ranges,0,160
.flash.rodata,80,80
.debug_str,0,59
.strtab,0,59
.flash.text,28,28
.debug_frame,0,24
.debug_aranges,0,8
.shstrtab,0,1
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,-3
.debug_abbrev,0,-15
.dram0.bss,-72,0
[Unmapped],0,-80

[github-actions]

Size increase report for "nrfconnect-example-build" from a95b622

File	Section	File	VM
chip-lighting.elf	rodata	72	76
chip-lighting.elf	text	48	48
chip-lighting.elf	[LOAD #3 [RW]]	0	8
chip-lighting.elf	bss	0	-72
chip-shell.elf	rodata	72	76
chip-shell.elf	text	52	52
chip-shell.elf	device_handles	-4	-4
chip-shell.elf	bss	0	-64
chip-lock.elf	rodata	80	76
chip-lock.elf	text	52	52
chip-lock.elf	device_handles	-4	-4
chip-lock.elf	[LOAD #3 [RW]]	0	-27
chip-lock.elf	bss	0	-69

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lighting.elf and ./pull_artifact/chip-lighting.elf:

sections,vmsize,filesize
.debug_info,0,652
.debug_line,0,242
.debug_ranges,0,240
.debug_loc,0,153
rodata,76,72
.debug_str,0,59
.strtab,0,59
text,48,48
.debug_abbrev,0,42
.symtab,0,32
[LOAD #3 [RW]],8,0
.debug_frame,0,4
.shstrtab,0,1
bss,-72,0

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,647
.debug_ranges,0,256
.debug_line,0,243
.debug_loc,0,169
rodata,76,72
.debug_str,0,59
.strtab,0,59
text,52,52
.debug_abbrev,0,42
.symtab,0,32
.shstrtab,0,1
device_handles,-4,-4
bss,-64,0

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,647
.debug_ranges,0,240
.debug_line,0,239
.debug_loc,0,161
rodata,76,80
.debug_str,0,59
.strtab,0,59
text,52,52
.debug_abbrev,0,42
.symtab,0,32
.debug_frame,0,4
.shstrtab,0,1
device_handles,-4,-4
[LOAD #3 [RW]],-27,0
bss,-69,0